Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook: ReferenceArea - ArgsTable #3432

Closed
nikolasrieble opened this issue Mar 4, 2023 · 0 comments
Closed

Storybook: ReferenceArea - ArgsTable #3432

nikolasrieble opened this issue Mar 4, 2023 · 0 comments
Labels
good first issue Issues with this label are great for first time contributors storybook Issues that require updating or creating stories in the storybook
Milestone
Storybook: Docume...

Comments

@nikolasrieble
Copy link
Contributor

Following the example set by Line.stories.tsx

Add descriptions and correct types to the ArgTable
Make sure to reuse shared descriptions (see storybook/stories/API/props/Legend.ts
Acceptance critera:
@ckifer ckifer added the storybook Issues that require updating or creating stories in the storybook label Mar 6, 2023
@lukask-proxora lukask-proxora mentioned this issue Mar 26, 2023
Merged
8 tasks
ckifer pushed a commit that referenced this issue Apr 7, 2023
@lukask-proxora
add arg table for ReferenceArea stories (#3486)
cb69aa7 
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue

#3432 
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):
![Screenshot from 2023-03-26
17-57-49](https://user-images.githubusercontent.com/102710733/227788351-1a3337c3-dc4d-48d6-a063-073e4f843694.png)
![Screenshot from 2023-03-26
17-57-43](https://user-images.githubusercontent.com/102710733/227788354-3ca5ba3e-c486-46c5-b971-897c7c7aa5ea.png)
![Screenshot from 2023-03-26
17-57-31](https://user-images.githubusercontent.com/102710733/227788356-8926efca-9258-4a1d-991a-210fef7e9d18.png)
![Screenshot from 2023-03-26
17-57-16](https://user-images.githubusercontent.com/102710733/227788361-89775d35-2b09-40c1-b54c-e3a5d7366a36.png)
![Screenshot from 2023-03-26
17-57-07](https://user-images.githubusercontent.com/102710733/227788366-8a26cecb-5446-4874-bd03-fc2eb93a5616.png)
![Screenshot from 2023-03-26
17-56-48](https://user-images.githubusercontent.com/102710733/227788371-820577b1-9854-4dc6-9734-4750e7838bc2.png)



## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] My code follows the code style of this project.
- [x] My change requires a change to the documentation.
- [x] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
@ckifer ckifer added the good first issue Issues with this label are great for first time contributors label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues with this label are great for first time contributors storybook Issues that require updating or creating stories in the storybook
Projects
None yet
Milestone
Storybook: Documentation and Testing
Development

No branches or pull requests
2 participants
@ckifer @nikolasrieble