storybook: document undocumented Polygon props #3587
Assignees
Labels
good first issue
Issues with this label are great for first time contributors
storybook
Issues that require updating or creating stories in the storybook
Comments
ckifer
added
the
storybook
ckifer
added
the
good first issue
7 tasks
ckifer
pushed a commit
that referenced
this issue
Jun 19, 2023
## Description Provide reasonable descriptions and stories for the Polygon props `connectNulls` and `baseLinePoints` ## Related Issue #3587 ## Motivation and Context Improving completeness of documentation ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> I made stories and made sure they do what I said they do ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Documentation enhancement ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [NA] I have added tests to cover my changes. - [x] All new and existing tests passed. Co-authored-by: Julianna Langston <julianna@cosaic.io>
|
Closed by #3631 |
GMer78
pushed a commit
to GMer78/recharts-1
that referenced
this issue
Nov 24, 2023
) ## Description Provide reasonable descriptions and stories for the Polygon props `connectNulls` and `baseLinePoints` ## Related Issue recharts#3587 ## Motivation and Context Improving completeness of documentation ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> I made stories and made sure they do what I said they do ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Documentation enhancement ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [NA] I have added tests to cover my changes. - [x] All new and existing tests passed. Co-authored-by: Julianna Langston <julianna@cosaic.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Documentation enhancement
Document undocumented properties of
Polygonmentioned in this PR #3586connectNulls,baseLinePointsRequirements
connectNullsdoes in context ofPolygonbaseLinePointsdoes in context ofPolygonPolygonstory storybookThe text was updated successfully, but these errors were encountered: