Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): add polygon story #3586

Merged
merged 1 commit into from May 15, 2023
Merged

docs(storybook): add polygon story #3586

merged 1 commit into from May 15, 2023

Conversation

ckifer
Copy link
Member

@ckifer ckifer commented May 15, 2023

Description

Polygon story files and initial simple story following examples of other shapes.

Leave out undocumented "internal" props connectNulls and baseLinePoints. These show in the args table but aren't called out in the current documentation. I don't know enough about them to add proper descriptions to them.

Related Issue

Motivation and Context

Continue to document things in storybook

How Has This Been Tested?

See screenshot. Tested locally, tests continue to pass.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@nikolasrieble nikolasrieble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first iteration. Can you please create a follow up tickets to document the two missing properties in storybook? Just so we not forget it.

@ckifer
Copy link
Member Author

ckifer commented May 15, 2023

#3587

@ckifer
Copy link
Member Author

ckifer commented May 15, 2023

Follow up issue created - merging

@ckifer ckifer merged commit 758205a into recharts:master May 15, 2023
5 checks passed
@ckifer ckifer deleted the sb/poly branch May 15, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants