Brush for line chart no longer shows anything other than the line components

[HerrPfister]

• I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Steps to reproduce

1. Create a
2. Add and components to it
3. Create a Brush and add it to the chart
4. Add the same and components to it
5. See how the lines appear in the brush but not the reference line and the cartesian grid is rendered oddly

What is expected?

All components rendered in the chart, and given to the brush chart, are rendered.

The Following image was created with version 2.10.4

What is actually happening?

All components rendered in the chart, and given to the brush chart, are not rendered.

The Following image was created with version 2.12.0

Environment	Info
Recharts	v2.12.0
React	React ^17.0.2
System	MacOS Sonoma 14.2.1
Browser	Chrome 120

[ckifer]

Thanks for the report. Looks like the change happened between 2.10.4 and 2.11.0. @recharts/maintainers FYI, will probably try to patch this in 2.x

[ckifer]

The cartesian grid behavior is the same, no change between 2.10.4 and 2.11/2.12

CartesianGrid behavior changes in 2.11 -> 2.12. Looks like we have two different issues

[ckifer]

@PavelVanecek I think this might be from context changes?

[PavelVanecek]

Possible! Did you find which commit causes the problem?

[ckifer]

No not yet unfortunately, wish we had a storybook entry with the graph-in-brush like this

[ckifer]

@PavelVanecek first issue (ReferenceLine) is probably from here 2e5f004

Second issue (CartesianGrid) is probably either 3eb2fb3 or b8575df

(not for sure tho)

[ckifer]

ReferenceLine issue confirmed this PR by checking out each commit #4033

ReferenceLine still gets rendered but at the wrong position because it uses the same points as the ReferenceLine in the main chart (though in the separate SVG)

Cartesian Grid issue from this PR confirmed by checking out each commit #4086

[ckifer]

Wrapping

if (compact) {... here https://github.com/recharts/recharts/blob/3.x/src/chart/generateCategoricalChart.tsx#L2210

in another chart layout context provider does the trick for both issues

[ckifer]

Fixed in 2.12.1 https://github.com/recharts/recharts/releases/tag/v2.12.1

[Yyana22]

Good afternoon. Can you please tell me how i can fix Brush in my lineChart ?


is it possible to make sure that the lines are not depending on the Brush for the entire graph, and not cut off?

my Brush:

<Brush
dataKey='timestamp'
tickFormatter={(date: Date) => parseAndFormatDate(date)}
/>