Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply className to the label and labelLine in PieChart component. #4378

Closed
1 task done
108yen opened this issue Apr 3, 2024 · 1 comment
Closed
1 task done

Apply className to the label and labelLine in PieChart component. #4378

108yen opened this issue Apr 3, 2024 · 1 comment

Comments

@108yen
Copy link
Contributor

108yen commented Apr 3, 2024

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

It would be possible to style each component with className.

What does the proposed API look like?

I want to apply a className to a PieChart component, as in the following example

        <PieChart {...args}>
          <Pie
            data={data}
            dataKey="uv"
            nameKey="name"
            innerRadius={50}
            outerRadius={80}
            label={{ className: 'label-custom-className' }}
            labelLine={{ className: 'label-line-custom-className' }}
          />
        </PieChart>
This was referenced Apr 3, 2024
Merged
Merged
ckifer pushed a commit that referenced this issue Apr 3, 2024
@108yen
feat(pie-chart): apply className to the label and labelLine (#4381
25c8bbd 
)

<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->
apply `className` to the `label` and `labelLine` in `PieChart`
component.

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->
#4378

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
Required if you want to assign `className` to the `PieChart` component.

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
Added unit test.

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] I have added a storybook story or extended an existing story to
show my changes
ckifer pushed a commit that referenced this issue Apr 3, 2024
@108yen
feat(pie-chart): apply className to the label and labelLine (#4379
8fb7133 
)

<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->
apply `className` to the `label` and `labelLine` in `PieChart`
component.

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->
#4378

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
Required if you want to assign `className` to the `PieChart` component.

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
Checked in storybook and passed existing tests.

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] I have added a storybook story or extended an existing story to
show my changes
@ckifer
Copy link
Member

ckifer commented Apr 3, 2024

merged and will be in the next patch release! Thanks @108yen !

@ckifer ckifer closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@108yen @ckifer