Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-chart): apply className to the label and labelLine #4379

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

108yen
Copy link
Contributor

@108yen 108yen commented Apr 3, 2024

Description

apply className to the label and labelLine in PieChart component.

Related Issue

#4378

Motivation and Context

Required if you want to assign className to the PieChart component.

How Has This Been Tested?

Checked in storybook and passed existing tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes

@PavelVanecek
Copy link
Collaborator

Hello @108yen , thank you for the PR. Can I please ask you to add unit tests for this change?

@108yen
Copy link
Contributor Author

108yen commented Apr 3, 2024

@PavelVanecek
Added unit test.

@ckifer ckifer merged commit 8fb7133 into recharts:3.x Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants