Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sankey types - add expliciy return type for renderTooltip #3581

Merged
merged 2 commits into from May 10, 2023

Conversation

ckifer
Copy link
Member

@ckifer ckifer commented May 10, 2023

Description

#3580

Broken types after refactoring Tooltip to a function component because renderTooltip of Sankey didn't explicitly set a return type. This confirms the flakiness of recharts types and the use of React.cloneElement.

Before any more refactoring changes try to build into a project and compile it with tsc

Related Issue

#3580

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ckifer ckifer merged commit ebaa111 into recharts:master May 10, 2023
5 checks passed
@ckifer ckifer deleted the fix/sankey-types branch May 10, 2023 21:56
renovate bot added a commit to SAP/ui5-webcomponents-react that referenced this pull request May 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [recharts](https://togithub.com/recharts/recharts) | [`2.5.0` ->
`2.6.2`](https://renovatebot.com/diffs/npm/recharts/2.5.0/2.6.2) |
[![age](https://badges.renovateapi.com/packages/npm/recharts/2.6.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/recharts/2.6.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/recharts/2.6.2/compatibility-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/recharts/2.6.2/confidence-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>recharts/recharts</summary>

###
[`v2.6.2`](https://togithub.com/recharts/recharts/releases/tag/v2.6.2)

[Compare
Source](https://togithub.com/recharts/recharts/compare/v2.6.1...v2.6.2)

fix bug where ts types error and cannot be generated when exporting in a
consuming package. Fixes
[recharts/recharts#3581

#### What's Changed

- fix: sankey types - add explicitly return type for renderTooltip by
[@&#8203;ckifer](https://togithub.com/ckifer) in
[recharts/recharts#3581

**Full Changelog**:
recharts/recharts@v2.6.1...v2.6.2

###
[`v2.6.1`](https://togithub.com/recharts/recharts/releases/tag/v2.6.1)

[Compare
Source](https://togithub.com/recharts/recharts/compare/v2.6.0...v2.6.1)

#### What's Changed

Quick fix for a bug crashing treemaps with tooltips in 2.6.0

- Fix treemap tooltip crash by
[@&#8203;ckifer](https://togithub.com/ckifer) in
[recharts/recharts#3579

**Full Changelog**:
recharts/recharts@v2.6.0...v2.6.1

###
[`v2.6.0`](https://togithub.com/recharts/recharts/releases/tag/v2.6.0)

[Compare
Source](https://togithub.com/recharts/recharts/compare/v2.5.0...v2.6.0)

#### What's Changed

Storybook documentation updates as well as our first accessibility
feature thanks to
[@&#8203;julianna-langston](https://togithub.com/julianna-langston) and
some refactoring to function components!

##### Feat

- \[a11y] Keyboard navigation support for categorical charts by
[@&#8203;julianna-langston](https://togithub.com/julianna-langston) in
[recharts/recharts#3546
- See docs
[here](https://release--63da8268a0da9970db6992aa.chromatic.com/?path=/docs/api-accessibility--docs)

##### Fix

- Update type for `equidistantPreserveStart` axis interval by
[@&#8203;frontier159](https://togithub.com/frontier159) in
[recharts/recharts#3511
- Stop focusing on tooltip when displayed - use event listeners instead
by [@&#8203;ArkaFred](https://togithub.com/ArkaFred) in
[recharts/recharts#3515

##### Docs

- lots of storybook changes - [go check it
out](https://release--63da8268a0da9970db6992aa.chromatic.com/)!
    -   Getting close to parity with existing docs on recharts.org
    -   Added accessibility add-on
- Added accessibility docs to go with the keyboard navigation support
    -   Storybook 7 stable
    -   Much more!

##### Refactor

- refactor: `Curve` to function component by
[@&#8203;akamfoad](https://togithub.com/akamfoad) in
[recharts/recharts#3477
- refactor: `PolarGrid` to function component by
[@&#8203;akamfoad](https://togithub.com/akamfoad) in
[recharts/recharts#3471
- refactor: `Cross` to component function by
[@&#8203;akamfoad](https://togithub.com/akamfoad) in
[recharts/recharts#3475
- refactor: tooltip to function component by
[@&#8203;ckifer](https://togithub.com/ckifer) in
[recharts/recharts#3336
- fix: defaultProps of tooltip, fix viewBox by
[@&#8203;ckifer](https://togithub.com/ckifer) in
[recharts/recharts#3554
- refactor: `Text` to function component by
[@&#8203;akamfoad](https://togithub.com/akamfoad) in
[recharts/recharts#3463

#### New Contributors

- [@&#8203;akamfoad](https://togithub.com/akamfoad) made their first
contribution in
[recharts/recharts#3466
- [@&#8203;nicholasgcoles](https://togithub.com/nicholasgcoles) made
their first contribution in
[recharts/recharts#3467
- [@&#8203;linhuiw](https://togithub.com/linhuiw) made their first
contribution in
[recharts/recharts#3508
- [@&#8203;frontier159](https://togithub.com/frontier159) made their
first contribution in
[recharts/recharts#3511
- [@&#8203;ArkaFred](https://togithub.com/ArkaFred) made their first
contribution in
[recharts/recharts#3515
- [@&#8203;julianna-langston](https://togithub.com/julianna-langston)
made their first contribution in
[recharts/recharts#3540

**Full Changelog**:
recharts/recharts@v2.5.0...v2.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/SAP/ui5-webcomponents-react).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43NC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lukas Harbarth <lukas.harbarth@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant