CartesianAxis: Improve interval option 'equidistantPreserveStart' #3768

nikolasrieble · 2023-09-20T11:43:45Z

Description

This PR overhauls the existing interval option equidistantPreserveStart

In this variant, we always show the first tick, and starting from the first, we find the smallest N, for which all n-th ticks can be shown without collision.

A collision is defined as two overlapping ticks, taking into account custom tick formatting, a unit, the fontsize, the angle, et cetera (in alignment with the other existing methods). An overlap is identified if the end of the previous tick overlaps with the start of the next one.

Downside of this method:

When the first tick is very long, hardly any other ticks will be shown.
Performance: Instead of iterating over the ticks once, as all other methods do, this method iterates at most M times, M being the total amount of available ticks (i.e. for 1000 datapoints, 1000 times). All other methods are thus more performant. This is a good candidate to discuss in review or to iterate upon.

Related Issue

#3305

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
I have added a storybook story or extended an existing story to show my changes
All new and existing tests passed.

nikolasrieble · 2023-09-20T12:53:20Z

Extracting #3769 from this PR to have a prefactoring PR without any behavioural change.

src/cartesian/CartesianAxis.tsx

…ts/recharts into nikolas.ticks.equidistant

nikolasrieble · 2023-09-21T12:39:31Z

nikolasrieble · 2023-09-21T19:21:48Z

@ckifer What do you think about:

Should we deprecate equidistantPreserveStart?

ckifer · 2023-09-21T19:27:05Z

I don't see an issue with deprecating it really except the fact that it was very recently introduced. I certainly wouldn't prefer it over the others.

We'd need to add a deprecation warning and then remove it on 3.0

nikolasrieble · 2023-09-21T20:35:06Z

test/cartesian/getEquidistantTicks.spec.ts

+    { ticksThatFit: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9], resultingTicks: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] },
+    { ticksThatFit: [0, 1, 2, 3, 4, 5, 6, 7, 8], resultingTicks: [0, 2, 4, 6, 8] },
+    { ticksThatFit: [0, 1, 2, 3, 4, 5, 6, 7], resultingTicks: [0, 5] },
+    { ticksThatFit: [0, 1, 2, 3, 4, 5, 6], resultingTicks: [0, 5] },
+    { ticksThatFit: [0, 1, 2, 3, 4, 5], resultingTicks: [0, 5] },
+    { ticksThatFit: [0, 1, 2, 3, 4], resultingTicks: [0] },


This section deserves scrutiny. Is this the behaviour we want to achieve?

is this really true in the browser though?

I feel like all of these should be able to fit? every time?

I kind of think we shouldn't always preserve start and instead show as many as we can while maintaining equidistance

I construct the ticks in the test such that this is true in the browser.
But good point, if we were to dynamically allow starting from any tick but still only show equidistant ticks, we could show much more.

Really, we could consider to redo the interface completely. As far as I understand it, the options currently are:

alwaysShowStart alwaysShowEnd collisionHandlingStrategy currentName

true false keep left preserveStart

false true keep right preserveEnd

true true keep left preserveStartEnd

true false compute collision to direct neighbour and then select every nTH equidistantPreserveStart

true false show every nTH without collision equidistant

We could have the option to choose equidistant without alwaysShowStart.

I admittedly find the naming of these strategies not that insightful. We should probably investigate how others do this.

The more I think about this, I believe we should simply replace the existing equidistantPreserveStart with this implementation.

This would be a breaking change, as it changes existing behaviour, but the change would only be to the better, namely we would show more ticks than we previously did, and there would yet be no collision.

@ckifer What do you think about this approach?

I like it, because it does not further complicate the API and it improves the existing behaviour (almost a bug fix)

I'm on board - if people complain that their chart looks better then... not sure lol. If anything we could do the same thing with preserveEnd if we wanted no?

Done. Thanks for the discussion.

I'm on board - of people complain that their chart looks better then... not sure lol. If anything we could do the same thing with preserveEnd if we wanted no?

They will look better, Coltin! :P

Exactly 🚀. If there are complaints I will say but... they look better 😂

ckifer

Looks good overall, I love how much the prefactoring helped here

test/cartesian/getEquidistantTicks.spec.ts

ckifer · 2023-09-22T05:54:17Z

test/cartesian/getEquidistantTicks.spec.ts

+    { ticksThatFit: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9], resultingTicks: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] },
+    { ticksThatFit: [0, 1, 2, 3, 4, 5, 6, 7, 8], resultingTicks: [0, 2, 4, 6, 8] },
+    { ticksThatFit: [0, 1, 2, 3, 4, 5, 6, 7], resultingTicks: [0, 5] },
+    { ticksThatFit: [0, 1, 2, 3, 4, 5, 6], resultingTicks: [0, 5] },
+    { ticksThatFit: [0, 1, 2, 3, 4, 5], resultingTicks: [0, 5] },
+    { ticksThatFit: [0, 1, 2, 3, 4], resultingTicks: [0] },


is this really true in the browser though?

I feel like all of these should be able to fit? every time?

I kind of think we shouldn't always preserve start and instead show as many as we can while maintaining equidistance

christopherkindl · 2023-09-22T20:52:31Z

Thanks so much for this improvement from the entire Tremor team!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [recharts](https://togithub.com/recharts/recharts) | [`2.8.0` -> `2.9.0`](https://renovatebot.com/diffs/npm/recharts/2.8.0/2.9.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/recharts/2.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/recharts/2.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/recharts/2.8.0/2.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/recharts/2.8.0/2.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>recharts/recharts (recharts)</summary> ### [`v2.9.0`](https://togithub.com/recharts/recharts/releases/tag/v2.9.0) [Compare Source](https://togithub.com/recharts/recharts/compare/v2.8.0...v2.9.0) #### What's Changed Quite a lot this minor release! We sent out a cry for help and many answered - thank you so much for that 🙌🏼 This release aims at internal maintainability, long lingering bugs, and needed improvements. Highlights include equidistant tick improvements, an active bar feature, and an ~85k/~9kb (gzipped) bundle size reduction 🚀 ##### Feat - `Bar`: Implement activeBar for Bar component by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3756 - `CartesianGrid`: add `syncWithticks`, `horizonalValues`, and `verticalValues` props to allow more grid line customization by [@morozovkirill](https://togithub.com/morozovkirill) in [recharts/recharts#3746 solves [recharts/recharts#2153 - `CartesianAxis`: Improve interval option 'equidistantPreserveStart' by [@nikolasrieble](https://togithub.com/nikolasrieble) in [recharts/recharts#3768 - `CartesianAxis`: Throw an invariant when axisIds do not match between chart and axis components by [@ckifer](https://togithub.com/ckifer) - `Brush`: add onDragEnd event to Brush component by [@simkesd](https://togithub.com/simkesd) in [recharts/recharts#3774 ##### Fix - Active Shape improvements - `Funnel`: activeShape should work with Tooltip by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3772 - `Scatter`: activeShape should work with Tooltip by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3839 - `Pie`: activeShape should work with Tooltip by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3818 - `RadialBar`: activeShape should work with Tooltip by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3803 - `CartesianGrid`: Remove offset attribute from lines by [@branberry](https://togithub.com/branberry) in [recharts/recharts#3854 solves [recharts/recharts#3810 - `ResponsiveContainer`: style prop is now passed down correctly by [@d-gottlieb](https://togithub.com/d-gottlieb) in [recharts/recharts#3726 - `Legend`: "Functions are not valid as a React child" error in <Legend/> when a function is passed as the payload [#3749](https://togithub.com/recharts/recharts/issues/3749) by [@chris-mcdonald-dev](https://togithub.com/chris-mcdonald-dev) in [recharts/recharts#3750 - `Tooltip`: Fix tooltip position when container uses transform scale by [@MateuszTrN](https://togithub.com/MateuszTrN) in [recharts/recharts#3748 - `Tooltip`: Tooltip does not include data from all charts when a separate dataset is passed to chart prop data and specified on Line/Area/etc prop data by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3733 fixes [recharts/recharts#3669 ##### Refactor Impossible to mention all of the great refactoring done this release thanks to [@PavelVanecek](https://togithub.com/PavelVanecek) (33 PRs in one month!!) and others! Notable improvements include (non-breaking) type safety enhancements and source code file size reductions, and unit test improvements that will help reduce regressions. ##### Chore - Upgrade react-smooth to 2.0.5 - potentially fixes [recharts/recharts#1135 (edit: this was already fixed) - Add performance testing tool by [@PavelVanecek](https://togithub.com/PavelVanecek) in [recharts/recharts#3829 - remove reduceCSSCalc by [@HHongSeungWoo](https://togithub.com/HHongSeungWoo) in [recharts/recharts#3820 ##### Storybook - Add storybook-addon-performance by [@PavelVanecek](https://togithub.com/PavelVanecek) in [recharts/recharts#3826 - many storybook improvements and fixes #### 🚀 New Contributors (!!) 🚀 - [@d-gottlieb](https://togithub.com/d-gottlieb) made their first contribution in [recharts/recharts#3726 - [@andrewangelle](https://togithub.com/andrewangelle) made their first contribution in [recharts/recharts#3733 - [@wanisramdani](https://togithub.com/wanisramdani) made their first contribution in [recharts/recharts#3751 - [@MateuszTrN](https://togithub.com/MateuszTrN) made their first contribution in [recharts/recharts#3748 - [@chris-mcdonald-dev](https://togithub.com/chris-mcdonald-dev) made their first contribution in [recharts/recharts#3750 - [@PavelVanecek](https://togithub.com/PavelVanecek) made their first contribution in [recharts/recharts#3759 - [@simkesd](https://togithub.com/simkesd) made their first contribution in [recharts/recharts#3774 - [@samtmorgan](https://togithub.com/samtmorgan) made their first contribution in [recharts/recharts#3778 - [@Shashangbhagat](https://togithub.com/Shashangbhagat) made their first contribution in [recharts/recharts#3786 - [@morozovkirill](https://togithub.com/morozovkirill) made their first contribution in [recharts/recharts#3746 - [@branberry](https://togithub.com/branberry) made their first contribution in [recharts/recharts#3854 - [@HHongSeungWoo](https://togithub.com/HHongSeungWoo) made their first contribution in [recharts/recharts#3820 **Full Changelog**: recharts/recharts@v2.8.0...v2.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SAP/ui5-webcomponents-react).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lukas Harbarth <lukas.harbarth@sap.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [recharts](https://togithub.com/recharts/recharts) | [`2.8.0` -> `2.9.3`](https://renovatebot.com/diffs/npm/recharts/2.8.0/2.9.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/recharts/2.9.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/recharts/2.9.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/recharts/2.8.0/2.9.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/recharts/2.8.0/2.9.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>recharts/recharts (recharts)</summary> ### [`v2.9.3`](https://togithub.com/recharts/recharts/releases/tag/v2.9.3) [Compare Source](https://togithub.com/recharts/recharts/compare/v2.9.2...v2.9.3) #### Fix `Brush`: Fix an issue where after 2.9 `Brush` does not correctly slice data when using `Line` components - fixes [recharts/recharts#3929 - thank you [@HHongSeungWoo](https://togithub.com/HHongSeungWoo) ### [`v2.9.2`](https://togithub.com/recharts/recharts/releases/tag/v2.9.2) [Compare Source](https://togithub.com/recharts/recharts/compare/v2.9.1...v2.9.2) Fix another TS issue from 2.9. ##### Fix - `Line/ActiveDot`: Fix breaking type change for the `onClick` function of `activeDot` on `Line` - this resolves [recharts/recharts#3922 - thank you [@andrewangelle](https://togithub.com/andrewangelle) for the quick turnaround ### [`v2.9.1`](https://togithub.com/recharts/recharts/releases/tag/v2.9.1) [Compare Source](https://togithub.com/recharts/recharts/compare/v2.9.0...v2.9.1) Bug fixes following 2.9.0 #### Fix - `TypeScript`: fix breaking change in `ActiveShape` types - fixes [recharts/recharts#3911 - thanks [@andrewangelle](https://togithub.com/andrewangelle) - `CartesianGrid`: fix breaking change where you could no longer render `CartesianGrid` without a y-axis - fixes [recharts/recharts#3907 - thanks [@akamfoad](https://togithub.com/akamfoad) - `Line`: fix infinite loop when `strokeDasharray` is `'0'` on `Line` - fixes [recharts/recharts#3899 (and maybe others) **Full Changelog**: recharts/recharts@v2.9.0...v2.9.1 ### [`v2.9.0`](https://togithub.com/recharts/recharts/releases/tag/v2.9.0) [Compare Source](https://togithub.com/recharts/recharts/compare/v2.8.0...v2.9.0) #### What's Changed Quite a lot this minor release! We sent out a cry for help and many answered - thank you so much for that 🙌🏼 This release aims at internal maintainability, long lingering bugs, and needed improvements. Highlights include equidistant tick improvements, an active bar feature, and an ~85k/~9kb (gzipped) bundle size reduction 🚀 ##### Feat - `Bar`: Implement activeBar for Bar component by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3756 - `CartesianGrid`: add `syncWithticks`, `horizonalValues`, and `verticalValues` props to allow more grid line customization by [@morozovkirill](https://togithub.com/morozovkirill) in [recharts/recharts#3746 solves [recharts/recharts#2153 - `CartesianAxis`: Improve interval option 'equidistantPreserveStart' by [@nikolasrieble](https://togithub.com/nikolasrieble) in [recharts/recharts#3768 - `CartesianAxis`: Throw an invariant when axisIds do not match between chart and axis components by [@ckifer](https://togithub.com/ckifer) - `Brush`: add onDragEnd event to Brush component by [@simkesd](https://togithub.com/simkesd) in [recharts/recharts#3774 ##### Fix - Active Shape improvements - `Funnel`: activeShape should work with Tooltip by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3772 - `Scatter`: activeShape should work with Tooltip by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3839 - `Pie`: activeShape should work with Tooltip by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3818 - `RadialBar`: activeShape should work with Tooltip by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3803 - `CartesianGrid`: Remove offset attribute from lines by [@branberry](https://togithub.com/branberry) in [recharts/recharts#3854 solves [recharts/recharts#3810 - `ResponsiveContainer`: style prop is now passed down correctly by [@d-gottlieb](https://togithub.com/d-gottlieb) in [recharts/recharts#3726 - `Legend`: "Functions are not valid as a React child" error in <Legend/> when a function is passed as the payload [#3749](https://togithub.com/recharts/recharts/issues/3749) by [@chris-mcdonald-dev](https://togithub.com/chris-mcdonald-dev) in [recharts/recharts#3750 - `Tooltip`: Fix tooltip position when container uses transform scale by [@MateuszTrN](https://togithub.com/MateuszTrN) in [recharts/recharts#3748 - `Tooltip`: Tooltip does not include data from all charts when a separate dataset is passed to chart prop data and specified on Line/Area/etc prop data by [@andrewangelle](https://togithub.com/andrewangelle) in [recharts/recharts#3733 fixes [recharts/recharts#3669 ##### Refactor Impossible to mention all of the great refactoring done this release thanks to [@PavelVanecek](https://togithub.com/PavelVanecek) (33 PRs in one month!!) and others! Notable improvements include (non-breaking) type safety enhancements and source code file size reductions, and unit test improvements that will help reduce regressions. ##### Chore - Upgrade react-smooth to 2.0.5 - potentially fixes [recharts/recharts#1135 (edit: this was already fixed) - Add performance testing tool by [@PavelVanecek](https://togithub.com/PavelVanecek) in [recharts/recharts#3829 - remove reduceCSSCalc by [@HHongSeungWoo](https://togithub.com/HHongSeungWoo) in [recharts/recharts#3820 ##### Storybook - Add storybook-addon-performance by [@PavelVanecek](https://togithub.com/PavelVanecek) in [recharts/recharts#3826 - many storybook improvements and fixes #### 🚀 New Contributors (!!) 🚀 - [@d-gottlieb](https://togithub.com/d-gottlieb) made their first contribution in [recharts/recharts#3726 - [@andrewangelle](https://togithub.com/andrewangelle) made their first contribution in [recharts/recharts#3733 - [@wanisramdani](https://togithub.com/wanisramdani) made their first contribution in [recharts/recharts#3751 - [@MateuszTrN](https://togithub.com/MateuszTrN) made their first contribution in [recharts/recharts#3748 - [@chris-mcdonald-dev](https://togithub.com/chris-mcdonald-dev) made their first contribution in [recharts/recharts#3750 - [@PavelVanecek](https://togithub.com/PavelVanecek) made their first contribution in [recharts/recharts#3759 - [@simkesd](https://togithub.com/simkesd) made their first contribution in [recharts/recharts#3774 - [@samtmorgan](https://togithub.com/samtmorgan) made their first contribution in [recharts/recharts#3778 - [@Shashangbhagat](https://togithub.com/Shashangbhagat) made their first contribution in [recharts/recharts#3786 - [@morozovkirill](https://togithub.com/morozovkirill) made their first contribution in [recharts/recharts#3746 - [@branberry](https://togithub.com/branberry) made their first contribution in [recharts/recharts#3854 - [@HHongSeungWoo](https://togithub.com/HHongSeungWoo) made their first contribution in [recharts/recharts#3820 **Full Changelog**: recharts/recharts@v2.8.0...v2.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…charts#3768)  ## Description This PR overhauls the existing interval option `equidistantPreserveStart` In this variant, we always show the first tick, and starting from the first, we find the smallest N, for which all n-th ticks can be shown without collision. A collision is defined as two overlapping ticks, taking into account custom tick formatting, a unit, the fontsize, the angle, et cetera (in alignment with the other existing methods). An overlap is identified if the end of the previous tick overlaps with the start of the next one. Downside of this method: - When the first tick is very long, hardly any other ticks will be shown. - Performance: Instead of iterating over the ticks once, as all other methods do, this method iterates at most M times, M being the total amount of available ticks (i.e. for 1000 datapoints, 1000 times). All other methods are thus more performant. This is a good candidate to discuss in review or to iterate upon.  ## Related Issue recharts#3305     ## How Has This Been Tested?    ## Screenshots (if appropriate): ## Types of changes  - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist:   - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ ] I have added a storybook story or extended an existing story to show my changes - [ ] All new and existing tests passed. --------- Co-authored-by: “Nikolas <“nikolas@rieble.com“>

“Nikolas added 9 commits September 11, 2023 21:49

First draft

abe0583

Functional implementation: Equidistant ticks

695514f

Extend Axisinterval type and add explanation

f2b74bc

Remove console logs

f79f31c

Extract TickUtils.spec.ts

65cbf21

Make eslint happy

6ba9807

TickUtils: Eslint must be happy

998d87d

getTicks: Eslint must be happy

26fb1ec

TickPositioning: Cleanup story

c7f51d2

nikolasrieble changed the title ~~Nikolas.ticks.equidistant~~ CartesianAxis: Extend interval API by 'equidistant' Sep 20, 2023

“Nikolas and others added 3 commits September 21, 2023 15:08

Merge remote-tracking branch 'origin' into nikolas.ticks.equidistant

ad76465

Merge branch 'master' into nikolas.ticks.equidistant

5ae63d5

Cleanup merge conflict properly

6852d43

nikolasrieble commented Sep 21, 2023

View reviewed changes

src/cartesian/CartesianAxis.tsx Outdated Show resolved Hide resolved

Nikolas Rieble and others added 3 commits September 21, 2023 14:24

Apply suggestions from code review

cb8ed8d

Merge branch 'nikolas.ticks.equidistant' of https://github.com/rechar…

0f0fd91

…ts/recharts into nikolas.ticks.equidistant

Storybook: Add margin

ee4eb1e

nikolasrieble marked this pull request as ready for review September 21, 2023 12:38

Add unit tests, and fix one edge case

257aef7

nikolasrieble commented Sep 21, 2023

View reviewed changes

ckifer approved these changes Sep 22, 2023

View reviewed changes

“Nikolas added 3 commits September 22, 2023 10:14

Review: Do not use lodash

9d49913

Review: Improve equidistantPreserveStart

bf89acd

Fix test

86fa0e3

nikolasrieble changed the title ~~CartesianAxis: Extend interval API by 'equidistant'~~ CartesianAxis: Improve interval option 'equidistantPreserveStart' Sep 22, 2023

nikolasrieble merged commit 1a70268 into master Sep 22, 2023
10 of 11 checks passed

nikolasrieble deleted the nikolas.ticks.equidistant branch September 22, 2023 15:24

christopherkindl mentioned this pull request Sep 22, 2023

[Bug]: Evenly spaced labels/ticks on axis tremorlabs/tremor#647

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CartesianAxis: Improve interval option 'equidistantPreserveStart' #3768

CartesianAxis: Improve interval option 'equidistantPreserveStart' #3768

nikolasrieble commented Sep 20, 2023 •

edited

nikolasrieble commented Sep 20, 2023

nikolasrieble commented Sep 21, 2023

nikolasrieble commented Sep 21, 2023

ckifer commented Sep 21, 2023

nikolasrieble Sep 21, 2023

ckifer Sep 22, 2023

nikolasrieble Sep 22, 2023

nikolasrieble Sep 22, 2023

nikolasrieble Sep 22, 2023

ckifer Sep 22, 2023 •

edited

nikolasrieble Sep 22, 2023

christopherkindl Sep 22, 2023

ckifer Sep 22, 2023

ckifer left a comment

ckifer Sep 22, 2023

christopherkindl commented Sep 22, 2023

alwaysShowStart	alwaysShowEnd	collisionHandlingStrategy	currentName
true	false	keep left	preserveStart
false	true	keep right	preserveEnd
true	true	keep left	preserveStartEnd
true	false	compute collision to direct neighbour and then select every nTH	equidistantPreserveStart
true	false	show every nTH without collision	equidistant

CartesianAxis: Improve interval option 'equidistantPreserveStart' #3768

CartesianAxis: Improve interval option 'equidistantPreserveStart' #3768

Conversation

nikolasrieble commented Sep 20, 2023 • edited

Description

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

nikolasrieble commented Sep 20, 2023

nikolasrieble commented Sep 21, 2023

nikolasrieble commented Sep 21, 2023

ckifer commented Sep 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ckifer Sep 22, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ckifer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christopherkindl commented Sep 22, 2023

nikolasrieble commented Sep 20, 2023 •

edited

ckifer Sep 22, 2023 •

edited