Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenClassificationRecord metadata menu seems to limit number of entries to 100 even if there are more in the dataset. #1387

Closed
coreyelowsky opened this issue Apr 7, 2022 · 3 comments · Fixed by #1396, #1399 or #1401
Assignees
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects

Comments

@coreyelowsky
Copy link

It seems as though the metadata drop down menu limits the amount of entries to only 100. Is it possible to expand this amount?

Screen Shot 2022-04-07 at 12 34 32 AM

@coreyelowsky coreyelowsky added the type: bug Indicates an unexpected problem or unintended behavior label Apr 7, 2022
@frascuchon
Copy link
Member

Hi @coreyelowsky and thanks a lot for all of your feedback.

The number of allowed metadata fields is configurable by the METADATA_FIELDS_LIMIT environment variable. As the default is defined as 50 and should not be greater than 100. In that sense, it should not be possible to have a dataset with a greater number of 100 different metadata fields.

I would like to know if you are able to manage a larger number of these data. We can also consider expanding the maximum number of metadata fields allowed, although it could affect the performance of the search engine.

@coreyelowsky
Copy link
Author

coreyelowsky commented Apr 8, 2022

@frascuchon

What I meant was not for more than 50 different metadata fields. But for just one specific metadata field, we have more than 100 unique values. As in the image above, for the specific metadata field called 'note_id', only 100 unique values show up in that dropdown shown, when we really have many more unique values for that specific field. Unless we mean the same thing?

@frascuchon
Copy link
Member

Ok, got it. Yes, we've set a limit to a max number of results for metadata filters, since they can directly impact performance.

We will increase the default value. And we can allow configuration by env var in future releases.

leiyre added a commit that referenced this issue Apr 11, 2022
fix #1387
This PR improves the performance of filter selectors by adding lazy loading and rendering only when they are visible.
@frascuchon frascuchon added this to Backlog in Release via automation Apr 11, 2022
@frascuchon frascuchon moved this from Backlog to In progress in Release Apr 11, 2022
Release automation moved this from In progress to Ready to DEV QA Apr 11, 2022
frascuchon pushed a commit that referenced this issue Apr 11, 2022
See #1387
This PR improves the performance of filter selectors by adding lazy loading and rendering only when they are visible.
@frascuchon frascuchon reopened this Apr 11, 2022
Release automation moved this from Ready to DEV QA to In progress Apr 11, 2022
Release automation moved this from In progress to Ready to DEV QA Apr 11, 2022
@frascuchon frascuchon reopened this Apr 11, 2022
Release automation moved this from Ready to DEV QA to In progress Apr 11, 2022
@frascuchon frascuchon moved this from In progress to Ready to DEV QA in Release Apr 11, 2022
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Apr 11, 2022
frascuchon added a commit that referenced this issue Apr 11, 2022
- fix(search): prevent exceed search.max buckets for metadata fields (#1401)
(cherry picked from commit 125c6b8)

- fix: improve performance of filter selectors (#1399)
(cherry picked from commit b6a8eae)

- fix(metrix): increment default aggregation size (#1396)
(cherry picked from commit 523ba44)
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Apr 11, 2022
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Apr 11, 2022
frascuchon added a commit that referenced this issue Apr 11, 2022
- fix(search): prevent exceed search.max buckets for metadata fields (#1401)
(cherry picked from commit 125c6b8)

- fix: improve performance of filter selectors (#1399)
(cherry picked from commit b6a8eae)

- fix(metrix): increment default aggregation size (#1396)
(cherry picked from commit 523ba44)
Release automation moved this from Approved Release QA to Ready to DEV QA Apr 13, 2022
@frascuchon frascuchon moved this from Ready to DEV QA to Ready to Release QA in Release Apr 13, 2022
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
4 participants