Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to master to fix bugs in tests #1057

Merged
merged 18 commits into from
Feb 27, 2020
Merged

Staging to master to fix bugs in tests #1057

merged 18 commits into from
Feb 27, 2020

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@yueguoguo
Copy link
Collaborator

What is the packaging_tutorial-CI?

@miguelgfierro
Copy link
Collaborator Author

What is the packaging_tutorial-CI?

@vapaunic do you know what is this? it links to https://vapaunic.visualstudio.com/154797b3-2afd-4ae1-87a4-bd7f650f039f/_build/results?buildId=18 but I can't access it

@vapaunic
Copy link

@miguelgfierro , this is a pipeline I built in my private devops account to package Recommenders and push it to Artifacts (just to try out what we were talking about). Didn't realize it was going to show up here, weird! I deleted the pipeline since. Could you push another commit, and see if it gets triggered again? It shouldn't.

@miguelgfierro
Copy link
Collaborator Author

ok thanks no problem, I think we can ignore it

@miguelgfierro miguelgfierro merged commit 7ff38ec into master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants