Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove n_users from RBM constructor #1622

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

pradnyeshjoshi
Copy link
Collaborator

@pradnyeshjoshi pradnyeshjoshi commented Jan 21, 2022

Description

Removed n_users argument from RBM constructor as it is not needed there. (It is only needed in the fit function and equals to the number of rows in the training set.)

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

Merging #1622 (48a9154) into staging (cf7bfd8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           staging    #1622   +/-   ##
========================================
  Coverage    56.68%   56.68%           
========================================
  Files           88       88           
  Lines         8956     8956           
========================================
  Hits          5077     5077           
  Misses        3879     3879           
Flag Coverage Δ
pr-gate 56.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/models/rbm/rbm.py 83.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735df87...48a9154. Read the comment docs.

@pradnyeshjoshi pradnyeshjoshi mentioned this pull request Jan 21, 2022
4 tasks
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@miguelgfierro miguelgfierro merged commit 9898ec6 into staging Jan 24, 2022
@miguelgfierro miguelgfierro deleted the pradjoshi/update_rbm_init branch January 24, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants