-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly test errors #2045
Fix nightly test errors #2045
Conversation
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have some questions
@@ -83,6 +83,7 @@ def test_cornac_deep_dive_runs(notebooks, output_notebook, kernel_name): | |||
|
|||
@pytest.mark.notebooks | |||
@pytest.mark.experimental | |||
@pytest.mark.skip(reason="rlrmc doesn't work with any officially released pymanopt package") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is problematic. I remember we were using a specific hash of pymanopt. @anargyri @pradnyeshjoshi do you guys remember which one?
@bamdevm @pradnyeshjoshi this notebook is failing, also we have the issue #1943 any possibility to help fix it or at least any guidance on how to solve the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, test_geoimc_functional
at the functional test also suffers the same issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have some questions
New commits fix functional test errors too. Only three functional tests, sasrec, benchmark_gpu and benchmark_cpu, are failing now: SASREC's hit@10
NCF's ndcg (from test_benchmark_movielens_gpu)
BPR's ndcg (from test_benchmark_movielens_cpu)
|
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
fixed those issues. |
this is great @loomlike, if the PR is ready, do you want to merge? |
* Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
* Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
* Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
* Issue with TF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update security tests Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Try to resolve #2018 Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Exclude tensorflow versions that are not supported Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct version comparison using packaging.version.Version Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Capture importerror Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Restrict tensorflow < 2.13 Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Set tensorflow < 2.12 Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Not triggering unit tests on Draft PR (#2033) * Not triggering unit tests on Draft PR Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Change a PR-triggering file to test Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> --------- Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Refactor ranking metric `map` to be the same as Spark's (#2004) * Announcement LF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update email Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update README.md Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * security Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * license and contribution notice Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * update author link Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Add new code of conduct from LF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Delete conda.md Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * list of test failing to fix Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update NEWS.md Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update README.md Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Change test names in the test group Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * remove unused input Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * no need to output the logs twice Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * packages Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * skipping flaky test Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Issue with TF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update security tests Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * list of test failing to fix Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Fix missing fixture error Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Add missing kernelspec language Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Remove scrapbook and papermill deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * notebook utils programmatic execution Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Test notebook programmatic Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Added test notebook for utils Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * data notebooks Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update new programmatic execution code Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update new programmatic execution code Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update notebooks with new utility Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Import missing store_metadata Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Merge multiline parameters into one line Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Increase timeout Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix nightly test errors (#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated PR template Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated PR template and contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * [Fix] correct MIND data construction of user behavior history Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update hybrid to CF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Replace LayerRNNCell with AbstractRNNCell Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Stop testing for deeprec Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Refactor ranking metric `map` to be the same as Spark's (#2004) * Announcement LF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update email Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update README.md Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * security Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * license and contribution notice Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * update author link Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Add new code of conduct from LF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Delete conda.md Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * list of test failing to fix Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update NEWS.md Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update README.md Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Change test names in the test group Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * remove unused input Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * no need to output the logs twice Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * packages Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * skipping flaky test Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Issue with TF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update security tests Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * list of test failing to fix Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Fix missing fixture error Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> * notebook utils programmatic execution Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Test notebook programmatic Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Added test notebook for utils Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update new programmatic execution code Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Update new programmatic execution code Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Update notebooks with new utility Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Import missing store_metadata Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Increase timeout Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix nightly test errors (#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated PR template Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Updated contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Updated PR template and contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Creating a jupyter book Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Creating documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Added rst files Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * license Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Weird warning with a link in the docstrings Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix docstring errors and replace .. note:: with Note: Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation dev Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Delete workflow and try via UI Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Added again the workflow Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * git add * -rf Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * git add * -f Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * add git info Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * actions to automatically update documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * actions to automatically update documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * trying github token Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * trying github token Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * trying github token and pull before pushing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * pull rebase Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * pull rebase and -Xtheirs Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * clean Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update documentation badge Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * install all deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * try adding other sphinx extensions Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Refact model rst Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * comment geoimc and rlrmc docs until issue is fixed Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Adding init and other special members Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Adding init and other special members Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Reviewing other rst Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Change sphinx version Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Change sphinx version and jupyter book Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Change the way we compile the documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Using the latest JB release Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Documentation working Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update docs/_config.yml Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update docs/requirements-doc.txt Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update docs/_config.yml Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Added comments by @SimonYansenZhao Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Upgrade versions of GitHub Actions See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update setup.py Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Try to disable sum and sum_component only Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Upgrade AzureML docker image Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct variable names Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Install git in the Conda env Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Disable test_xdeepfm_component_definition Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Use latest CUDA Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct GPU selection Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Remove leading whitespaces in Dockerfile Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Simplify azureml-test/action.yml Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Install wget in Docker image Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> Co-authored-by: thaiminhpv <thaiminhpv@gmail.com>
* Issue with TF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update security tests Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Try to resolve recommenders-team#2018 Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Exclude tensorflow versions that are not supported Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct version comparison using packaging.version.Version Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Capture importerror Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Restrict tensorflow < 2.13 Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Set tensorflow < 2.12 Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Not triggering unit tests on Draft PR (recommenders-team#2033) * Not triggering unit tests on Draft PR Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Change a PR-triggering file to test Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> --------- Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Refactor ranking metric `map` to be the same as Spark's (recommenders-team#2004) * Announcement LF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update email Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update README.md Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * security Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * license and contribution notice Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * update author link Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Add new code of conduct from LF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Delete conda.md Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * list of test failing to fix Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update NEWS.md Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update README.md Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Change test names in the test group Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * remove unused input Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * no need to output the logs twice Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * packages Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * skipping flaky test Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Issue with TF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update security tests Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * list of test failing to fix Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Fix missing fixture error Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Add missing kernelspec language Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Remove scrapbook and papermill deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * notebook utils programmatic execution Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Test notebook programmatic Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Added test notebook for utils Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * data notebooks Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update new programmatic execution code Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update new programmatic execution code Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update notebooks with new utility Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Import missing store_metadata Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Merge multiline parameters into one line Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Increase timeout Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix nightly test errors (recommenders-team#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated PR template Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated PR template and contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * [Fix] correct MIND data construction of user behavior history Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update hybrid to CF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Replace LayerRNNCell with AbstractRNNCell Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Stop testing for deeprec Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Refactor ranking metric `map` to be the same as Spark's (recommenders-team#2004) * Announcement LF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update email Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update README.md Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * security Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * license and contribution notice Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * update author link Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Add new code of conduct from LF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Delete conda.md Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * list of test failing to fix Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update NEWS.md Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update README.md Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Change test names in the test group Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * remove unused input Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * no need to output the logs twice Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * packages Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * skipping flaky test Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Issue with TF Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update security tests Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * list of test failing to fix Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Fix missing fixture error Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> * notebook utils programmatic execution Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Test notebook programmatic Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Added test notebook for utils Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update new programmatic execution code Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Update new programmatic execution code Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Update notebooks with new utility Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Import missing store_metadata Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Increase timeout Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix nightly test errors (recommenders-team#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated PR template Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Updated contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Updated PR template and contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Updated contributing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * change path hybrid Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Creating a jupyter book Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Creating documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * WIP Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Added rst files Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * license Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Weird warning with a link in the docstrings Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Fix docstring errors and replace .. note:: with Note: Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation dev Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Automatic build of documentation deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Delete workflow and try via UI Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Added again the workflow Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * git add * -rf Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * git add * -f Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * add git info Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * actions to automatically update documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * actions to automatically update documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * trying github token Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * trying github token Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * trying github token and pull before pushing Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * pull rebase Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * pull rebase and -Xtheirs Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * clean Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update documentation badge Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * install all deps Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * try adding other sphinx extensions Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Refact model rst Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * comment geoimc and rlrmc docs until issue is fixed Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * 📝 Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Adding init and other special members Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Adding init and other special members Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Reviewing other rst Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Change sphinx version Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Change sphinx version and jupyter book Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Change the way we compile the documentation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Using the latest JB release Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Documentation working Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update docs/_config.yml Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update docs/requirements-doc.txt Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update docs/_config.yml Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Added comments by @SimonYansenZhao Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Upgrade versions of GitHub Actions See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update setup.py Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Try to disable sum and sum_component only Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Upgrade AzureML docker image Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct variable names Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Install git in the Conda env Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Disable test_xdeepfm_component_definition Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Use latest CUDA Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Correct GPU selection Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Remove leading whitespaces in Dockerfile Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Simplify azureml-test/action.yml Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Install wget in Docker image Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Update Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com> Co-authored-by: thaiminhpv <thaiminhpv@gmail.com>
Description
Fix nightly test errors
Related Issues
#2041
#2035
Checklist:
staging branch
and not tomain branch
.