Fixed bug when reading dataset with timestamp for sasrec model #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staging to main: license update, tests
Staging to main: Remove support for Python 3.7 and redefinition of tests
Staging to main: LF announcement and GRU update
Staging to main: security fix due to Tensorflow
Staging to main: Fix bug in MAP and added new notebook programmatic execution
Fixed bug with reading dataset with splitting dataset with timestamp
gazon1
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
added exception for unkown count of columns
fixed typo
gazon1
changed the title
|
Hi @gazon1, would you mind changing the PR to staging, and signing the commit? |
|
All the test pass: #2060 merging this PR |
miguelgfierro
merged commit 2c22f5e
into
recommenders-team:staging
1 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When reading dataset with timestamp sasrec model would never use timestamp and it would crash with an error when splitting dataset with timestamp
Related Issues
References
Checklist:
staging branchand not tomain branch.