fix new_kappa allocation #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous script, the allocation of new_kappa using param["kappa"] was interfering with the pointer definition. It was then causing errors in the computation of the new and old likelihoods (new_likelihood then corresponded to the old_likelihood). In outbreaker_find_imports: there was a mistake in the position of the parentheses for the calculation of n_measures.
|
Cheers for that @alxsrobert, sorry for slow reply I was away at a conference. Funnily enough I found that bug a couple weeks ago too, turns out I'd only pushed the fix to my own fork and not the main fork! I will be doing a merge of your bug fixes and some of my own additions over the next couple days. Turns out there was actually a theoretical bug in the genetic likelihood itself, which unfortunately may have affected kappa estimates. I will post to the README describing the changes in the likelihood when I merge my fork. Thanks again! |
|
I'll leave this one with you both - thanks! :) Probably stating the obvious, but best make sure that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous script, the allocation of new_kappa using param["kappa"] was interfering with the pointer definition. It was then causing errors in the computation of the new and old likelihoods (new_likelihood then corresponded to the old_likelihood).
In outbreaker_find_imports: there was a mistake in the position of the parentheses for the calculation of n_measures.