Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotting changes, minor bug fixes, test changes for R 4.0 #25

Merged
merged 9 commits into from
Jun 3, 2020
Merged

plotting changes, minor bug fixes, test changes for R 4.0 #25

merged 9 commits into from
Jun 3, 2020

Conversation

TimTaylor
Copy link
Member

@TimTaylor TimTaylor commented May 4, 2020

This PR does the following:

  • Generalise the plot function to accept a y-label and graph title. Hopefully the use of null arguments will mean this is not a breaking change.
  • adds a new constructor function within build_projections that will hopefully make it a little easier to create subclasses if we want to in future.
  • fixes bug that caused using str on a projections object to error.
  • fixes bug in regards to subsetting by dates with the [.projections function. Note this was never tested for but was described in the docs. I've not implemented any checks yet.
  • added a todo in regards to documenting that build_projections can be used on a df. This was something that was tested for but not documented so I was unsure if you wanted it highlighted - hence the todo.
  • I've included some fixes for test errors caused by the move to R4.0. I think these are only intermediate fixes as once you are satisfied behaviour is the same you could probably rebuild the .rds with the current R version. This would also allow you to drop the RNGversion("3.5.3") dependency.
  • related to above changes to NAMESPACE, DESCRIPTION and .rd files.

Note - I have been unable to install vdiffr on my local machine so have not considered the image tests.

Changes are grouped by commit so hopefully easy to follow and disregard any that you don't like.

@TimTaylor TimTaylor changed the title generalise plot to accept ylabel and title arguments plotting changes, minor bug fixes, test changes for R 4.0 May 6, 2020
@thibautjombart thibautjombart merged commit f837a63 into reconhub:master Jun 3, 2020
@thibautjombart
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants