Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability Database #38

Open
noraj opened this issue May 26, 2021 · 24 comments
Open

Vulnerability Database #38

noraj opened this issue May 26, 2021 · 24 comments
Assignees
Labels
enhancement New feature or request pinned Pinned issues are not automatically closed by the evil stale bot.
Projects

Comments

@noraj
Copy link

noraj commented May 26, 2021

Actual behavior

Vulnerabilities are linked to a project and are either created manually from scratch or imported from tools integration.

Expected behavior

Having a vulnerability database like in PwnDoc (best implementation I saw).

Dradis, Ghostwriter, PwnDoc, WriteHat, etc. many collaborative penetration test reporting platforms have that, sometimes under a different name like issue library etc.

The idea is that you can save generic vulnerabilities since description and recommendation will always be the same or will require very few changes, you link the same resources, have the same title etc. So when you do a new pentest you can import a vulnerability in your audit/project an just have to change very few things and add your observations, details and proof and re-use most of the rest. And so saving a lot of time and not re-writing the same vulns at each new pentest.

Screenshots from PwnDoc

You can browse your vulnerability DB alone

image

Or add a vuln from your vuln DB into an audit

image

Feedback

Reconmap seems the most completed project, there is already a large panel of features, it's well maintained, It's own of the rare project using markdown for vulnerabilities description (most are using plaintext or HTML), there is a fair amount of tools integration, a CLI tool, backup capacity, etc. Looks just awesome 🤩

The Vulnerability Database seems the only missing major feature.

@santiagolizardo santiagolizardo self-assigned this May 26, 2021
@santiagolizardo santiagolizardo added this to To do in Reconmap v1 via automation May 26, 2021
@santiagolizardo santiagolizardo added the enhancement New feature or request label May 26, 2021
@santiagolizardo
Copy link
Member

Hi @noraj ; Thanks for your amazingly well reported issue/feature request. I took some time yesterday to address it and is now available to see at https://demo.reconmap.org
Essentially what I have done was to replicate the project templates for vulnerabilities, so that you can have a list of vulnerabilities templates that could be cloned and added to projects.
Hope you like it! :)

@santiagolizardo
Copy link
Member

Closing this now, feel free to open new issues if you have additional ideas on how to make this tool better.

Reconmap v1 automation moved this from To do to Done May 28, 2021
@noraj
Copy link
Author

noraj commented May 28, 2021

Wow amazing I wasn't expecting the feature to be implemented so fast.

So actually the workflow to create a vuln template is:

  • Create a vulnerability
  • Mark it as template
  • Save

And to add a vuln in your project from a template:

I have several suggestions.

And to add a vuln in your project from a template

The workflow mentioned above feels a bit unnatural and cumbersome. Ideally there would be two workflows:

  1. From the project
  • Next to Add vulnerability add a button Import vulnerability from template vith a view allowing to search through the vuln templates and tick checkbox to select one or several vulnerabilities from there to import to the project.
  1. From the vulnerability template list
  • Add an edit button to just edit the template
  • Rename the clone and edit button to Add to project that send you to a view where there is just a project and target to choose and save, and after saving that send you to the vuln instance in your project where you are free to edit the vulnerability. If it's too much work an easier option would be to rename the clone and edit button to Add to project where Is template? is unchecked by default and hidden.

Template

At the vulnerability template list (https://demo.reconmap.org/vulnerabilities/templates) having a create button (same as create vulnerability but with Is template? already checked. So you don't have to go to the vulnerability list, click create , check the box and can stay on the template page and just click create.

Search

There is no search bar specific to the vulnerability list or vulnerability template list but the global one.

The global search bar is very nice but the issue are:

  • You don't know if the results are vulnerabilities from a project or a vulnerability template
  • When having the same vuln added to several project, the project is not displayed so you have identical result rows

image

I suggest adding a project column display the project the vulnerability belong too and display Template if it's a template.

Removing a vulnerability from a project

From the project vulnerability view there is no remove button

image

One have to go to the global vulnerability list (https://demo.reconmap.org/vulnerabilities), find it there and delete it.

image

It would be nice to have the ability to remove it directly from the project too.

@noraj
Copy link
Author

noraj commented May 28, 2021

PS: let me know if you want I create separate issues for each feedback for better tracking or if it's ok to have all 4 here since they are related.

@santiagolizardo
Copy link
Member

You have done it again @noraj ! Great feedback :)
It all makes sense and luckily nothing of the above is difficult to implement. I'll get this done over the next couple of days 👍🏼

Reconmap v1 automation moved this from Done to To do May 28, 2021
@noraj
Copy link
Author

noraj commented May 28, 2021

The project if very promising, I'll start to write a script to convert PwnDoc vulnerability database (YAML) to ReconMap format that is importable. When done I'll share it with you. I may plan to install ReconMap for my personal need and I'm looking forward to contribute to the project more in the future (especially some tool importer plugins).

@blockanz
Copy link

The project if very promising, I'll start to write a script to convert PwnDoc vulnerability database (YAML) to ReconMap format that is importable. When done I'll share it with you. I may plan to install ReconMap for my personal need and I'm looking forward to contribute to the project more in the future (especially some tool importer plugins).

Did this work ever get completed? I'd be keen to test and try it if so.

@noraj
Copy link
Author

noraj commented Jul 16, 2021

Did this work ever get completed? I'd be keen to test and try it if so.

I did not started it yet. I'll let you know.

@cbk914
Copy link

cbk914 commented Jul 28, 2021

The demo site is not working, there's some way to import the report templates and the vulnerabilities from Github into the Reconmap WUI?

@noraj
Copy link
Author

noraj commented Aug 4, 2021

Checklist #38 (comment)

  • add a vuln in your project from a template
  • Template
  • Search
  • Removing a vulnerability from a project

@noraj noraj mentioned this issue Aug 4, 2021
3 tasks
@santiagolizardo
Copy link
Member

One can be removed from the list ;)

  • Remove a vulnerability from a project

@santiagolizardo
Copy link
Member

Another one to mark as completed. Search now makes a distinction between results and result templates.

image

image

Hope this is useful @noraj

@noraj
Copy link
Author

noraj commented Aug 6, 2021

Another one to mark as completed. Search now makes a distinction between results and result templates.

Yeah and it also display the project when there is several projects with the same vuln :)

@stale
Copy link

stale bot commented Sep 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 5, 2021
@noraj
Copy link
Author

noraj commented Sep 5, 2021

unstale

@stale stale bot removed the wontfix This will not be worked on label Sep 5, 2021
@stale
Copy link

stale bot commented Oct 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 5, 2021
@santiagolizardo santiagolizardo removed the wontfix This will not be worked on label Oct 5, 2021
@noraj
Copy link
Author

noraj commented Oct 7, 2021

So only the add a vuln in your project from a template remains.
I made a HTML preview of what it could look likes..
image
But as those buttons are quiet large maybe a multi-choice drop-down button like for github merge would be better :
image

@stale
Copy link

stale bot commented Nov 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 6, 2021
@noraj
Copy link
Author

noraj commented Nov 6, 2021

unstale

@stale stale bot removed the wontfix This will not be worked on label Nov 6, 2021
@stale
Copy link

stale bot commented Dec 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 6, 2021
@noraj
Copy link
Author

noraj commented Dec 7, 2021

unstale

@stale stale bot removed the wontfix This will not be worked on label Dec 7, 2021
@stale
Copy link

stale bot commented Jan 6, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 6, 2022
@santiagolizardo santiagolizardo added pinned Pinned issues are not automatically closed by the evil stale bot. and removed wontfix This will not be worked on labels Jan 8, 2022
@santiagolizardo santiagolizardo removed this from To do in Reconmap v1 Mar 4, 2022
@santiagolizardo santiagolizardo added this to To do in Reconmap v2 via automation Mar 4, 2022
@noraj
Copy link
Author

noraj commented Mar 27, 2022

@santiagolizardo How do you add a vulnerability to a project from a template? Actually you can only add a blank one.

@psyray
Copy link

psyray commented Mar 4, 2023

@santiagolizardo Is it possible to add the button to import vulnerabilities template ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned Pinned issues are not automatically closed by the evil stale bot.
Projects
Reconmap v2
  
To do
Development

No branches or pull requests

5 participants