Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WHO Situation Report 1-24 data for SARS-CoV-2 outbreak (COVID-19) #27

Merged
merged 3 commits into from
Feb 17, 2020

Conversation

eebrown
Copy link
Contributor

@eebrown eebrown commented Feb 14, 2020

I've added the WHO Situation Report data. I modified the variable names to be consistent with your package. I've got a small script I can run to update it from my original data, so I can keep it updated from time to time.

@finlaycampbell
Copy link
Collaborator

This is great, thanks. Could you make two small changes before I merge the pull request?

  1. Change the version number to 1.8, because this is adding a new 'feature'
  2. Resave your .RData file using version = 2 in your save call. I'm getting the following warning and we want to keep the current R dependency:
     WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects:  'outbreaks/data/sarscov2_who_2019.RData'

@eebrown
Copy link
Contributor Author

eebrown commented Feb 15, 2020

Great, think it should be good now. I'll push an update from time to time. This is how to easily use my other package as "upstream" for the data object here: https://gist.github.com/eebrown/3f25afe42ed126803be819940356c0b7

@finlaycampbell finlaycampbell merged commit 140261e into reconverse:master Feb 17, 2020
@finlaycampbell
Copy link
Collaborator

Great, thanks a bunch!

@eebrown eebrown mentioned this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants