[DowngradePhp73] Ensure reset() after go to end() array and got the key on DowngradeArrayKeyFirstLastRector #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
samsonasik
changed the title
|
@samsonasik I also tested this PR on my codebase and the endless loops are still gone 😄 Again, thanks for quick response! 👍 |
|
@kapersoft thank you for testing, this applied to many location on downgraded scope code so it definatelly fix many possible infinite loop due to many |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kapersoft @TomasVotruba here the proper solution to fix rectorphp/rector#8531