Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DataProviderArrayItemsNewlinedRector to rector-phpunit #287

Closed
eerison opened this issue Nov 6, 2023 · 1 comment · Fixed by #290
Closed

Move DataProviderArrayItemsNewlinedRector to rector-phpunit #287

eerison opened this issue Nov 6, 2023 · 1 comment · Fixed by #290

Comments

@eerison
Copy link
Contributor

eerison commented Nov 6, 2023 •
edited
Loading

Shouldn't this rule DataProviderArrayItemsNewlinedRector be placed in this repository instead of main repository?

in theory yes https://github.com/rectorphp/rector/blob/main/rules/CodingStyle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector.php#L96

😄
@TomasVotruba
Copy link
Member

That would be better location indeed :)

eerison pushed a commit to eerison/rector-phpunit that referenced this issue Nov 7, 2023
Feature/287 Add Coding style
5988696 
- Move `DataProviderArrayItemsNewLinedRector` from rector repository.
- Add test for DataProviderArrayItemsNewLinedRector
- Add group rule set for coding style

Issue rectorphp#287
@eerison eerison mentioned this issue Nov 7, 2023
Merged
eerison pushed a commit to eerison/rector-phpunit that referenced this issue Nov 7, 2023
Feature/287 Move DataProviderArrayItemsNewLinedRector to rector-phpunit
606f6fd 
- Move `DataProviderArrayItemsNewLinedRector` from rector repository.
- Add test for DataProviderArrayItemsNewLinedRector
- Add DataProviderArrayItemsNewLinedRector in code quality rules

Issue rectorphp#287
eerison pushed a commit to eerison/rector-phpunit that referenced this issue Nov 7, 2023
Fix/287 Move tests from rector-src related with DataProviderAnnotatio…
5fcf9c4 
…nToAttributeRector

Close rectorphp#287
eerison pushed a commit to eerison/rector-src that referenced this issue Nov 7, 2023
Remove rule DataProviderArrayItemsNewlinedRector.php
f6a5768 
This rule was moved to rector-phpunit

Issue rectorphp/rector-phpunit#287
This was referenced Nov 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TomasVotruba @eerison