Add class-leak to composer scripts
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to increase its visibility - to fix errors locally instead of seeing on GH Actions
samsonasik
approved these changes
Apr 3, 2024
|
Thank you @maks-rafalko |
maks-rafalko
added a commit
to maks-rafalko/rector-phpunit
that referenced
this pull request
Apr 8, 2024
…d line on GH action This is a follow up for rectorphp#320 and related to rectorphp#319 (comment) Instead of duplicating command line on `code_analysis.yaml` action file, we can just reuse `composer class-leak` from `composer.json`. Each time `composer class-leak` is updated, it will be automatically used on GH Action, so no need to update duplicated command twice. Without it, we will have an issue when we start addign `--skip-type` for `vendor/bin/class-leak` in `code_analysis.yaml`. The same `--skip-type` would be added to 2 places without this PR.
TomasVotruba
pushed a commit
that referenced
this pull request
Apr 8, 2024
…d line on GH action (#323) This is a follow up for #320 and related to #319 (comment) Instead of duplicating command line on `code_analysis.yaml` action file, we can just reuse `composer class-leak` from `composer.json`. Each time `composer class-leak` is updated, it will be automatically used on GH Action, so no need to update duplicated command twice. Without it, we will have an issue when we start addign `--skip-type` for `vendor/bin/class-leak` in `code_analysis.yaml`. The same `--skip-type` would be added to 2 places without this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally found here: #319 (comment)