Skip non-final class method with no content in AddVoidReturnTypeWhere…

…NoReturnRector (#5386)

* Skip non-final class method with no content

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

rules-tests/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/Fixture/skip_non_final_empty.php.inc

@@ -0,0 +1,10 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector\Fixture;
+
+class SkipNonFinalEmpty
+{
+    public function getItem()
+    {
+    }
+}

rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php

@@ -76,7 +76,8 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if ($node->returnType !== null) {
+        // already has return type → skip
+        if ($node->returnType instanceof Node) {
             return null;
         }
 
@@ -120,6 +121,11 @@ private function shouldSkipClassMethod(ClassMethod|Function_|Closure $functionLi
             return true;
         }
 
+        // possibly required by child implementation
+        if ($this->isNotFinalAndEmpty($functionLike)) {
+            return true;
+        }
+
         if ($functionLike->isProtected()) {
             return ! $this->classModifierChecker->isInsideFinalClass($functionLike);
         }
@@ -140,4 +146,13 @@ private function isNotFinalAndHasExceptionOnly(ClassMethod $classMethod): bool
         $onlyStmt = $classMethod->stmts[0] ?? null;
         return $onlyStmt instanceof Throw_;
     }
+
+    private function isNotFinalAndEmpty(ClassMethod $classMethod): bool
+    {
+        if ($this->classModifierChecker->isInsideFinalClass($classMethod)) {
+            return false;
+        }
+
+        return $classMethod->stmts === [];
+    }
 }