Fix make ReadOnlyPropertyRector skip if traits are used, as not relia…

…ble (#5548)

* Added test case property declared readonly when only set in trait

* make ReadOnlyPropertyRector skip if traits are used, as not reliable

---------

Co-authored-by: David Grüner <david@vworld.at>

rules-tests/Php81/Rector/Property/ReadOnlyPropertyRector/Fixture/skip_write_in_trait_property.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\Property\ReadOnlyPropertyRector\Fixture;
+
+use stdClass;
+
+final class SkipWriteInTraitProperty
+{
+    use WritableTrait;
+
+    public function __construct(private stdClass $myProperty)
+    {
+    }
+}
+
+trait WritableTrait
+{
+    public function setProperty(stdClass $myProperty): void
+    {
+        $this->myProperty = $myProperty;
+    }
+}

rules/Php81/Rector/Property/ReadOnlyPropertyRector.php

@@ -240,6 +240,11 @@ private function shouldSkip(Class_ $class): bool
             return true;
         }
 
+        // not safe
+        if ($class->getTraitUses() !== []) {
+            return true;
+        }
+
         // skip "clone $this" cases, as can create unexpected write to local constructor property
         return $this->hasCloneThis($class);
     }