[CodingStyle] Remove OrderAttributesRector, as rather coding standard…

… and does not have specific PSR example (#3838)
rectorphp · May 14, 2023 · 07a7876 · 07a7876
1 parent ad70120
commit 07a7876
Show file tree

Hide file tree

Showing 37 changed files with 12 additions and 676 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
@@ -1,4 +1,4 @@
-# 411 Rules Overview
+# 410 Rules Overview
 
 <br>
 
@@ -8,7 +8,7 @@
 
 - [CodeQuality](#codequality) (76)
 
-- [CodingStyle](#codingstyle) (36)
+- [CodingStyle](#codingstyle) (35)
 
 - [Compatibility](#compatibility) (1)
 
@@ -2174,71 +2174,6 @@ Changes already typed Type|null to ?Type
 
 <br>
 
-### OrderAttributesRector
-
-Order attributes by desired names
-
-:wrench: **configure it!**
-
-- class: [`Rector\CodingStyle\Rector\ClassMethod\OrderAttributesRector`](../rules/CodingStyle/Rector/ClassMethod/OrderAttributesRector.php)
-
-```php
-<?php
-
-declare(strict_types=1);
-
-use Rector\CodingStyle\Rector\ClassMethod\OrderAttributesRector;
-use Rector\Config\RectorConfig;
-
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->ruleWithConfiguration(OrderAttributesRector::class, [
-        'First',
-        'Second',
-    ]);
-};
-```
-
-↓
-
-```diff
-+#[First]
- #[Second]
--#[First]
- class Someclass
- {
- }
-```
-
-<br>
-
-```php
-<?php
-
-declare(strict_types=1);
-
-use Rector\CodingStyle\Rector\ClassMethod\OrderAttributesRector;
-use Rector\Config\RectorConfig;
-
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->ruleWithConfiguration(OrderAttributesRector::class, [
-        'alphabetically',
-    ]);
-};
-```
-
-↓
-
-```diff
-+#[AAttribute]
- #[BAttribute]
--#[AAttribute]
- class Someclass
- {
- }
-```
-
-<br>
-
 ### PostIncDecToPreIncDecRector
 
 Use ++$value or --$value  instead of `$value++` or `$value--`

diff --git a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ByRefReturnNodeVisitor.php b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ByRefReturnNodeVisitor.php
@@ -11,8 +11,8 @@
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 use Rector\NodeTypeResolver\Node\AttributeKey;
-use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 use Rector\NodeTypeResolver\PHPStan\Scope\Contract\NodeVisitor\ScopeResolverNodeVisitorInterface;
+use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 
 final class ByRefReturnNodeVisitor extends NodeVisitorAbstract implements ScopeResolverNodeVisitorInterface
 {

diff --git a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ByRefVariableNodeVisitor.php b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ByRefVariableNodeVisitor.php
@@ -11,8 +11,8 @@
 use PhpParser\Node\FunctionLike;
 use PhpParser\NodeVisitorAbstract;
 use Rector\NodeTypeResolver\Node\AttributeKey;
-use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 use Rector\NodeTypeResolver\PHPStan\Scope\Contract\NodeVisitor\ScopeResolverNodeVisitorInterface;
+use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 
 final class ByRefVariableNodeVisitor extends NodeVisitorAbstract implements ScopeResolverNodeVisitorInterface
 {

diff --git a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/GlobalVariableNodeVisitor.php b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/GlobalVariableNodeVisitor.php
@@ -13,8 +13,8 @@
 use PhpParser\NodeVisitorAbstract;
 use Rector\Core\Contract\PhpParser\Node\StmtsAwareInterface;
 use Rector\NodeTypeResolver\Node\AttributeKey;
-use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 use Rector\NodeTypeResolver\PHPStan\Scope\Contract\NodeVisitor\ScopeResolverNodeVisitorInterface;
+use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 
 final class GlobalVariableNodeVisitor extends NodeVisitorAbstract implements ScopeResolverNodeVisitorInterface
 {

diff --git a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/StaticVariableNodeVisitor.php b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/StaticVariableNodeVisitor.php
@@ -13,8 +13,8 @@
 use PhpParser\NodeVisitorAbstract;
 use Rector\Core\Contract\PhpParser\Node\StmtsAwareInterface;
 use Rector\NodeTypeResolver\Node\AttributeKey;
-use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 use Rector\NodeTypeResolver\PHPStan\Scope\Contract\NodeVisitor\ScopeResolverNodeVisitorInterface;
+use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 
 final class StaticVariableNodeVisitor extends NodeVisitorAbstract implements ScopeResolverNodeVisitorInterface
 {

diff --git a/...tributesRector/AlphabeticallOrder/Fixture/first_from_multiple_attr_in_attr_groups.php.inc b/...tributesRector/AlphabeticallOrder/Fixture/first_from_multiple_attr_in_attr_groups.php.inc
diff --git a/...le/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Fixture/one_around.php.inc b/...le/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Fixture/one_around.php.inc
diff --git a/.../ClassMethod/OrderAttributesRector/AlphabeticallOrder/Fixture/skip_expected_order.php.inc b/.../ClassMethod/OrderAttributesRector/AlphabeticallOrder/Fixture/skip_expected_order.php.inc
diff --git a/...butesRector/AlphabeticallOrder/Fixture/skip_expected_order_with_annotation_around.php.inc b/...butesRector/AlphabeticallOrder/Fixture/skip_expected_order_with_annotation_around.php.inc
diff --git a/.../OrderAttributesRector/AlphabeticallOrder/Fixture/skip_expected_order_with_around.php.inc b/.../OrderAttributesRector/AlphabeticallOrder/Fixture/skip_expected_order_with_around.php.inc
diff --git a/...le/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Fixture/some_class.php.inc b/...le/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Fixture/some_class.php.inc
diff --git a/...Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/OrderAttributesRectorTest.php b/...Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/OrderAttributesRectorTest.php
diff --git a/...ngStyle/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Source/AAttribute.php b/...ngStyle/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Source/AAttribute.php
diff --git a/...ngStyle/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Source/BAttribute.php b/...ngStyle/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Source/BAttribute.php
diff --git a/...ngStyle/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Source/CAttribute.php b/...ngStyle/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/Source/CAttribute.php
diff --git a/...le/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/config/configured_rule.php b/...le/Rector/ClassMethod/OrderAttributesRector/AlphabeticallOrder/config/configured_rule.php
diff --git a/...derAttributesRector/SpecificOrder/Fixture/first_from_multiple_attr_in_attr_groups.php.inc b/...derAttributesRector/SpecificOrder/Fixture/first_from_multiple_attr_in_attr_groups.php.inc