[Privatization] Skip abstract class in PrivatizeLocalPropertyToPrivat…

…ePropertyRector
rectorphp · Jun 12, 2021 · 09251da · 09251da
1 parent 8ebc4fe
commit 09251da
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 64 deletions.
diff --git a/...r/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/include_abstract.php.inc b/...r/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/include_abstract.php.inc
diff --git a/...roperty/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_abstract_class.php.inc b/...roperty/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_abstract_class.php.inc
@@ -0,0 +1,8 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
+
+abstract class SkipAbstractClass
+{
+    public $some;
+}
diff --git a/...izeLocalPropertyToPrivatePropertyRector/FixtureOpenSource/skip_protected_abstract.php.inc b/...izeLocalPropertyToPrivatePropertyRector/FixtureOpenSource/skip_protected_abstract.php.inc
diff --git a/...on/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/OpenSourceRectorTest.php b/...on/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/OpenSourceRectorTest.php
diff --git a/rules/Privatization/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector.php b/rules/Privatization/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector.php
@@ -158,8 +158,8 @@ private function shouldSkipClass(ClassLike $classLike): bool
             return true;
         }
 
-        if (! $classLike->isAbstract()) {
-            return false;
+        if ($classLike->isAbstract()) {
+            return true;
         }
 
         return $this->isOpenSourceProjectType();