AddMethodCallBasedStrictParamTypeRector: Support changing protected m…

…ethods in final classes (#4611)

* AddMethodCallBasedStrictParamTypeRector: Support changing protected methods in final classes

* Update final_class_without_extends.php.inc

* Create skip_final_class_with_extends.php.inc

* Update skip_final_class_with_extends.php.inc

* Create skip_non_final_class_without_extends.php.inc

* fix per review

* Support final methods without base-types

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/final_class_without_extends.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+final class ProtectedMethodInFinalClassWithoutBaseClass
+{
+    public function runFirst(string $data)
+    {
+        $this->process($data);
+    }
+
+    protected function process($data)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+final class ProtectedMethodInFinalClassWithoutBaseClass
+{
+    public function runFirst(string $data)
+    {
+        $this->process($data);
+    }
+
+    protected function process(string $data)
+    {
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/final_method_without_extends.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+class FinalProtectedMethodInClassWithoutBaseClass
+{
+    public function runFirst(string $data)
+    {
+        $this->process($data);
+    }
+
+    final protected function process($data)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+class FinalProtectedMethodInClassWithoutBaseClass
+{
+    public function runFirst(string $data)
+    {
+        $this->process($data);
+    }
+
+    final protected function process(string $data)
+    {
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/skip_final_class_with_extends.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+final class SkipProtectedMethodInFinalClassWithBaseClass extends SomeClass
+{
+    public function runFirst(string $data)
+    {
+        $this->process($data);
+    }
+
+    protected function process($data)
+    {
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/skip_final_class_with_implements.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+final class ProtectedMethodInFinalClassImplementingInterface implements SomeUnknownInterface
+{
+    public function runFirst(string $data)
+    {
+        $this->process($data);
+    }
+
+    protected function process($data)
+    {
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/skip_non_final_class_without_extends.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+class SkipProtectedMethodInNonFinalClassWithoutBaseClass
+{
+    public function runFirst(string $data)
+    {
+        $this->process($data);
+    }
+
+    protected function process($data)
+    {
+    }
+}
+
+?>

rules/TypeDeclaration/Rector/ClassMethod/AddMethodCallBasedStrictParamTypeRector.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use Rector\Core\PhpParser\NodeFinder\LocalMethodCallFinder;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Reflection\ReflectionResolver;
 use Rector\TypeDeclaration\NodeAnalyzer\CallTypesResolver;
 use Rector\TypeDeclaration\NodeAnalyzer\ClassMethodParamTypeCompleter;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -88,7 +89,18 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
-            if (! $method->isPrivate()) {
+            $isPrivate =
+                ($node->isFinal()
+                && $node->extends === null
+                && $node->implements === []
+                && $method->isProtected())
+                || ($method->isFinal()
+                    && $node->extends === null
+                    && $node->implements === []
+                )
+                || $method->isPrivate();
+
+            if (!$isPrivate) {
                 continue;
             }