AddMethodCallBasedStrictParamTypeRector: Support changing protected methods in final classes #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
samsonasik
reviewed
Jul 27, 2023
| if (! $method->isPrivate()) { | ||
| $isPrivate = | ||
| ($node->isFinal() | ||
| && $node->extends === null |
There was a problem hiding this comment.
$node->implements empty should be checked as well, also probably used by/from trait.
service from Parent override guard or FamilyTree services may be can be used for this case
There was a problem hiding this comment.
good point. added a test-case and fixed it
There was a problem hiding this comment.
I did not use the suggested services, as I think pure AST based decision are more reliable right now
There was a problem hiding this comment.
Ok, lets use this as initial support and then we can improve later with verify parent FullyQualified->toString() is autoloaded
samsonasik
approved these changes
Jul 27, 2023
|
Thank you @staabm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.