[Transform] Skip different method on CallableInMethodCallToVariableRe…

…ctor (#2395) * [Transform] Skip different method on CallableInMethodCallToVariableRector * [Transform] Skip different method on CallableInMethodCallToVariableRector * [Transform] Skip different method on CallableInMethodCallToVariableRector * Fixed 🎉 * cs * fix code analysis dev
rectorphp · May 30, 2022 · 0dc9777 · 0dc9777
1 parent 7df41da
commit 0dc9777
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/.github/workflows/code_analysis_no_dev.yaml b/.github/workflows/code_analysis_no_dev.yaml
@@ -25,5 +25,7 @@ jobs:
                 rm phpstan-for-rector.neon
                 touch phpstan-for-rector.neon
 
-            -   run: composer install --no-progress --ansi --no-dev
-            -   run: bin/rector list --ansi
+            -  run: |
+                 composer install --ansi
+                 composer install --no-progress --ansi --no-dev
+            -  run: bin/rector list --ansi
diff --git a/...tor/MethodCall/CallableInMethodCallToVariableRector/Fixture/skip_different_method.php.inc b/...tor/MethodCall/CallableInMethodCallToVariableRector/Fixture/skip_different_method.php.inc
@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\Transform\Rector\MethodCall\CallableInMethodCallToVariableRector\Fixture;
+
+use Rector\Tests\Transform\Rector\MethodCall\CallableInMethodCallToVariableRector\Source\DummyCache;
+
+final class SkipDifferentMethod
+{
+    public function run(DummyCache $dummyCache, $someValue)
+    {
+        $dummyCache->load('key', function ($someValue) {
+            $someValue= $someValue + 1000;
+            return $someValue + 10;
+        });
+    }
+}
diff --git a/rules/Transform/Rector/MethodCall/CallableInMethodCallToVariableRector.php b/rules/Transform/Rector/MethodCall/CallableInMethodCallToVariableRector.php
@@ -86,6 +86,13 @@ public function refactor(Node $node): ?MethodCall
                 continue;
             }
 
+            if (! $this->nodeNameResolver->isName(
+                $node->name,
+                $singleCallableInMethodCallToVariable->getMethodName()
+            )) {
+                continue;
+            }
+
             $position = $singleCallableInMethodCallToVariable->getArgumentPosition();
             if (! isset($node->args[$position])) {
                 continue;