Skip to content

Commit

Permalink
remove --dry-run to pass
Browse files Browse the repository at this point in the history
  • Loading branch information
@TomasVotruba
TomasVotruba committed Sep 27, 2023
1 parent 9cc5329 commit 16ba249
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build/target-repository/.github/workflows/e2e.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ jobs:
working-directory: ${{ matrix.directory }}

-
run: vendor/bin/rector process --ansi
run: vendor/bin/rector process --dry-run --ansi
working-directory: ${{ matrix.directory }}
2 changes: 1 addition & 1 deletion build/target-repository/.github/workflows/e2e_diff.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ jobs:
working-directory: ${{ matrix.directory }}

-
run: vendor/bin/rector process --dry-run --ansi
run: vendor/bin/rector process --ansi

This comment has been minimized.

Sign in to view

Copy link
@samsonasik

samsonasik Sep 27, 2023

Member

not sure why, but when on php 7.x, the diff should not shown:

1 file with changes
===================

1) src/route.php:3

    ---------- begin diff ----------
@@ @@

 class SomeController
 {
-    /**
-     * @Route()
-     */
+    #[Route]
     public function someMethod()
     {
     }
    ----------- end diff -----------

Applied rules:
 * AnnotationToAttributeRector (https://wiki.php.net/rfc/attributes_v2)

This comment has been minimized.

Sign in to view

Copy link
@samsonasik

samsonasik Sep 27, 2023

Member

it seems due to php config set

rector-src/build/target-repository/e2e/attributes/rector.php

Line 12 in 16ba249

$rectorConfig->phpVersion(PhpVersion::PHP_80);

working-directory: ${{ matrix.directory }}

0 comments on commit 16ba249

Please sign in to comment.