[TypeDeclaration] Adds AddParamTypeForFunctionLikeWithinCallLikeArgDe…

…clarationRector rule (#5547)

* Adds AddParamTypeForFunctionLikeWithinCallLikeDeclarationRector rule

* Add skip test for named parameters

* PHPStan fix

* Adds the ability to use named parameters as well as position

* Better naming of rule

* Reset hasChanged state

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

* Reject first class callable

---------

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

build/target-repository/docs/rector_rules_overview.md

@@ -56,7 +56,7 @@
 
 - [Transform](#transform) (23)
 
-- [TypeDeclaration](#typedeclaration) (43)
+- [TypeDeclaration](#typedeclaration) (44)
 
 - [Visibility](#visibility) (3)
 
@@ -6406,6 +6406,21 @@ Add param types where needed
 
 <br>
 
+### AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector
+
+Add param types where needed
+
+:wrench: **configure it!**
+
+- class: [`Rector\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector`](../rules/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector.php)
+
+```diff
+-(new SomeClass)->process(function ($parameter) {});
++(new SomeClass)->process(function (string $parameter) {});
+```
+
+<br>
+
 ### AddParamTypeFromPropertyTypeRector
 
 Adds param type declaration based on property type the value is assigned to PHPUnit provider return type declaration

rules-tests/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector/Fixture/fixture.php.inc

@@ -0,0 +1,51 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Fixture;
+
+use SomeNamespace\SomeClass;
+use SomeNamespace\SomeClassForNamed;
+
+SomeClass::someCall(function ($name) {
+    return $name;
+});
+
+$var = new SomeClass();
+$var->someCall(function ($name) {
+    return $name;
+});
+
+(new SomeClass())->someCall(function ($name) {
+    return $name;
+});
+
+$var->someCall(fn ($name) => $name);
+
+SomeClassForNamed::someCall('a', 'b', callback: fn ($var) => $var);
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Fixture;
+
+use SomeNamespace\SomeClass;
+use SomeNamespace\SomeClassForNamed;
+
+SomeClass::someCall(function (string $name) {
+    return $name;
+});
+
+$var = new SomeClass();
+$var->someCall(function (string $name) {
+    return $name;
+});
+
+(new SomeClass())->someCall(function (string $name) {
+    return $name;
+});
+
+$var->someCall(fn (string $name) => $name);
+
+SomeClassForNamed::someCall('a', 'b', callback: fn (string $var) => $var);
+
+?>

rules-tests/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector/Fixture/overrides_previous_type.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Fixture;
+
+use SomeNamespace\SomeClass;
+
+SomeClass::someCall(fn(int|string $var) => $var);
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Fixture;
+
+use SomeNamespace\SomeClass;
+
+SomeClass::someCall(fn(string $var) => $var);
+
+?>

rules-tests/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector/Fixture/skip_if_calllike_arg_is_named.php.inc

@@ -0,0 +1,9 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Source\ClassForNamedParameters;
+
+SomeClass::someCall(anotherCallback: fn ($var) => $var, callback: fn($var) => $var);
+
+?>

rules-tests/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector/Fixture/skip_if_non_functionlike_parameter_missing.php.inc

@@ -0,0 +1,7 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Fixture;
+
+use SomeNamespace\SomeClass;
+
+SomeClass::someCall(fn() => 'test');

rules-tests/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector/Fixture/skip_if_non_functionlike_parameters_in_method_call.php.inc

@@ -0,0 +1,7 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Fixture;
+
+use SomeNamespace\SomeClass;
+
+SomeClass::someCall('test');

rules-tests/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector/Fixture/skip_if_non_matching_class.php.inc

@@ -0,0 +1,9 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Fixture;
+
+use SomeNamespace\SomeClass;
+
+AnotherClass::someCall(function ($name) {
+    return $name;
+});

rules-tests/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector/Fixture/skip_if_non_matching_method.php.inc

@@ -0,0 +1,9 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector\Fixture;
+
+use SomeNamespace\SomeClass;
+
+SomeClass::someOtherCall(function ($name) {
+    return $name;
+});

rules-tests/TypeDeclaration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector/config/configured_rule.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+use PHPStan\Type\StringType;
+use Rector\Config\RectorConfig;
+use Rector\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector;
+use Rector\TypeDeclaration\ValueObject\AddParamTypeForFunctionLikeWithinCallLikeArgDeclaration;
+use Rector\ValueObject\PhpVersionFeature;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig
+        ->ruleWithConfiguration(AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector::class, [
+            new AddParamTypeForFunctionLikeWithinCallLikeArgDeclaration(
+                'SomeNamespace\SomeClass',
+                'someCall',
+                0,
+                0,
+                new StringType()
+            ),
+            new AddParamTypeForFunctionLikeWithinCallLikeArgDeclaration(
+                'SomeNamespace\SomeClassForNamed',
+                'someCall',
+                'callback',
+                0,
+                new StringType()
+            ),
+        ]);
+
+    $rectorConfig->phpVersion(PhpVersionFeature::MIXED_TYPE);
+};