New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeDeclaration] Adds AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector rule #5547
Merged
TomasVotruba
merged 9 commits into
rectorphp:main
from
peterfox:feature/add-param-type-for-function-like-within-method-call-declaration-rector
Feb 22, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfox
force-pushed
the
feature/add-param-type-for-function-like-within-method-call-declaration-rector
branch
from
February 4, 2024 10:58
2561766
to
de98d5c
Compare
peterfox
force-pushed
the
feature/add-param-type-for-function-like-within-method-call-declaration-rector
branch
from
February 4, 2024 15:34
de98d5c
to
b416e12
Compare
peterfox
changed the title
[TypeDeclaration] Adds AddParamTypeForFunctionLikeWithinCallLikeDeclarationRector rule
[TypeDeclaration] Adds AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector rule
Feb 4, 2024
samsonasik
reviewed
Feb 18, 2024
...ration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector.php
Show resolved
Hide resolved
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
…-type-for-function-like-within-method-call-declaration-rector # Conflicts: # build/target-repository/docs/rector_rules_overview.md
…call-declaration-rector' of github.com:peterfox/rector-src into feature/add-param-type-for-function-like-within-method-call-declaration-rector
samsonasik
reviewed
Feb 18, 2024
...ration/Rector/FunctionLike/AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector.php
Show resolved
Hide resolved
samsonasik
approved these changes
Feb 18, 2024
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
The benefits are hopefully obvious. In PHP frameworks like Laravel, methods etc. are often used with FunctionLike parameters but it can be difficult to know the correct type for Parameters. This rule would allow for enforcing types on method and static calls.
Using example parameters:
Notes
Both numeric position and named args for a CallLike are supported but positional args are ignored if they have a name. For example if you wanted to cover both scenarios in a code base you could reference the position and the named arg successfully and not worry about declaring the type on the wrong param.