[DX] Lower readonly PropertyManipulator complexity (#4429)

rectorphp · Jul 6, 2023 · 1d0feb2 · 1d0feb2
1 parent 3962227
commit 1d0feb2
Show file tree

Hide file tree

Showing 15 changed files with 34 additions and 497 deletions.
diff --git a/packages/NodeNestingScope/ParentScopeFinder.php b/packages/NodeNestingScope/ParentScopeFinder.php
diff --git a/packages/NodeTypeResolver/Node/AttributeKey.php b/packages/NodeTypeResolver/Node/AttributeKey.php
@@ -296,4 +296,9 @@ final class AttributeKey
      * @var string
      */
     public const FROM_FUNC_CALL_NAME = 'from_func_call_name';
+
+    /**
+     * @var string
+     */
+    public const INSIDE_ARRAY_DIM_FETCH = 'inside_array_dim_fetch';
 }
diff --git a/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ContextNodeVisitor.php b/packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ContextNodeVisitor.php
@@ -9,6 +9,7 @@
 use PhpParser\Node\Attribute;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Array_;
+use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\Isset_;
 use PhpParser\Node\Stmt\Break_;
@@ -43,6 +44,10 @@ public function enterNode(Node $node): ?Node
             return null;
         }
 
+        if ($node instanceof ArrayDimFetch) {
+            $node->var->setAttribute(AttributeKey::INSIDE_ARRAY_DIM_FETCH, true);
+        }
+
         if ($node instanceof Isset_ || $node instanceof Unset_) {
             $this->processContextInIssetOrUnset($node);
             return null;

diff --git a/packages/ReadWrite/Contract/ReadNodeAnalyzerInterface.php b/packages/ReadWrite/Contract/ReadNodeAnalyzerInterface.php
diff --git a/packages/ReadWrite/NodeAnalyzer/ReadExprAnalyzer.php b/packages/ReadWrite/NodeAnalyzer/ReadExprAnalyzer.php
diff --git a/packages/ReadWrite/NodeAnalyzer/ReadWritePropertyAnalyzer.php b/packages/ReadWrite/NodeAnalyzer/ReadWritePropertyAnalyzer.php
diff --git a/packages/ReadWrite/NodeFinder/NodeUsageFinder.php b/packages/ReadWrite/NodeFinder/NodeUsageFinder.php
diff --git a/packages/ReadWrite/ReadNodeAnalyzer/JustReadExprAnalyzer.php b/packages/ReadWrite/ReadNodeAnalyzer/JustReadExprAnalyzer.php
diff --git a/packages/ReadWrite/ReadNodeAnalyzer/LocalPropertyFetchReadNodeAnalyzer.php b/packages/ReadWrite/ReadNodeAnalyzer/LocalPropertyFetchReadNodeAnalyzer.php