fix multiple variants, see deprecated-packages/symplify#3375

rectorphp · Jun 30, 2021 · 1d1c723 · 1d1c723
1 parent 8926f8e
commit 1d1c723
Showing 1 changed file with 15 additions and 16 deletions.
diff --git a/rules/Php70/Rector/FuncCall/NonVariableToVariableOnFunctionCallRector.php b/rules/Php70/Rector/FuncCall/NonVariableToVariableOnFunctionCallRector.php
@@ -20,7 +20,6 @@
 use PHPStan\Analyser\MutatingScope;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ParameterReflection;
-use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\MixedType;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\Reflection\ReflectionResolver;
@@ -119,26 +118,26 @@ private function getNonVariableArguments(FuncCall | MethodCall | StaticCall $cal
             return [];
         }
 
-        $parametersAcceptor = ParametersAcceptorSelector::selectSingle($functionLikeReflection->getVariants());
+        foreach ($functionLikeReflection->getVariants() as $parametersAcceptor) {
+            /** @var ParameterReflection $parameterReflection */
+            foreach ($parametersAcceptor->getParameters() as $key => $parameterReflection) {
+                // omitted optional parameter
+                if (! isset($call->args[$key])) {
+                    continue;
+                }
 
-        /** @var ParameterReflection $parameterReflection */
-        foreach ($parametersAcceptor->getParameters() as $key => $parameterReflection) {
-            // omitted optional parameter
-            if (! isset($call->args[$key])) {
-                continue;
-            }
+                if ($parameterReflection->passedByReference()->no()) {
+                    continue;
+                }
 
-            if ($parameterReflection->passedByReference()->no()) {
-                continue;
-            }
+                $argument = $call->args[$key]->value;
 
-            $argument = $call->args[$key]->value;
+                if ($this->isVariableLikeNode($argument)) {
+                    continue;
+                }
 
-            if ($this->isVariableLikeNode($argument)) {
-                continue;
+                $arguments[$key] = $argument;
             }
-
-            $arguments[$key] = $argument;
         }
 
         return $arguments;