[ECS] Add parallel run with 16x time faster ECS (#925)

* [ecs] add parallel run * fix cs
rectorphp · Sep 27, 2021 · 1d9803c · 1d9803c
1 parent 17cfa9f
commit 1d9803c
Show file tree

Hide file tree

Showing 16 changed files with 63 additions and 43 deletions.
diff --git a/ecs.php b/ecs.php
@@ -37,6 +37,9 @@
 
     $parameters = $containerConfigurator->parameters();
 
+    // bleeding edge 16x faster speed
+    $parameters->set(Option::PARALLEL, true);
+
     $parameters->set(Option::PATHS, [
         __DIR__ . '/bin',
         __DIR__ . '/src',

diff --git a/rules/CodeQuality/Rector/FuncCall/ChangeArrayPushToArrayAssignRector.php b/rules/CodeQuality/Rector/FuncCall/ChangeArrayPushToArrayAssignRector.php
@@ -91,7 +91,7 @@ public function refactor(Node $node): ?Node
         $arrayDimFetch = new ArrayDimFetch($node->args[0]->value);
 
         $position = 1;
-        while (isset($node->args[$position]) &&  $node->args[$position] instanceof Arg) {
+        while (isset($node->args[$position]) && $node->args[$position] instanceof Arg) {
             $assign = new Assign($arrayDimFetch, $node->args[$position]->value);
             $assignExpression = new Expression($assign);
 

diff --git a/rules/CodeQuality/Rector/FuncCall/InArrayAndArrayKeysToArrayKeyExistsRector.php b/rules/CodeQuality/Rector/FuncCall/InArrayAndArrayKeysToArrayKeyExistsRector.php
@@ -18,8 +18,9 @@
  */
 final class InArrayAndArrayKeysToArrayKeyExistsRector extends AbstractRector
 {
-    public function __construct(private ArgsAnalyzer $argsAnalyzer)
-    {
+    public function __construct(
+        private ArgsAnalyzer $argsAnalyzer
+    ) {
     }
 
     public function getRuleDefinition(): RuleDefinition

diff --git a/rules/CodeQuality/Rector/FuncCall/RemoveSoleValueSprintfRector.php b/rules/CodeQuality/Rector/FuncCall/RemoveSoleValueSprintfRector.php
@@ -19,8 +19,9 @@
  */
 final class RemoveSoleValueSprintfRector extends AbstractRector
 {
-    public function __construct(private ArgsAnalyzer $argsAnalyzer)
-    {
+    public function __construct(
+        private ArgsAnalyzer $argsAnalyzer
+    ) {
     }
 
     public function getRuleDefinition(): RuleDefinition

diff --git a/rules/CodeQuality/Rector/FuncCall/SetTypeToCastRector.php b/rules/CodeQuality/Rector/FuncCall/SetTypeToCastRector.php
@@ -45,8 +45,9 @@ final class SetTypeToCastRector extends AbstractRector
         'string' => String_::class,
     ];
 
-    public function __construct(private ArgsAnalyzer $argsAnalyzer)
-    {
+    public function __construct(
+        private ArgsAnalyzer $argsAnalyzer
+    ) {
     }
 
     public function getRuleDefinition(): RuleDefinition

diff --git a/rules/CodeQuality/Rector/FuncCall/SimplifyFuncGetArgsCountRector.php b/rules/CodeQuality/Rector/FuncCall/SimplifyFuncGetArgsCountRector.php
@@ -41,7 +41,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if (!  $node->args[0] instanceof Arg) {
+        if (! $node->args[0] instanceof Arg) {
             return null;
         }
 

diff --git a/rules/CodeQuality/Rector/FuncCall/UnwrapSprintfOneArgumentRector.php b/rules/CodeQuality/Rector/FuncCall/UnwrapSprintfOneArgumentRector.php
@@ -18,8 +18,9 @@
  */
 final class UnwrapSprintfOneArgumentRector extends AbstractRector
 {
-    public function __construct(private ArgsAnalyzer $argsAnalyzer)
-    {
+    public function __construct(
+        private ArgsAnalyzer $argsAnalyzer
+    ) {
     }
 
     public function getRuleDefinition(): RuleDefinition

diff --git a/rules/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector.php b/rules/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector.php
@@ -25,8 +25,9 @@
  */
 final class SimplifyIfIssetToNullCoalescingRector extends AbstractRector
 {
-    public function __construct(private ArgsAnalyzer $argsAnalyzer)
-    {
+    public function __construct(
+        private ArgsAnalyzer $argsAnalyzer
+    ) {
     }
 
     public function getRuleDefinition(): RuleDefinition

diff --git a/rules/CodingStyle/Rector/FuncCall/VersionCompareFuncCallToConstantRector.php b/rules/CodingStyle/Rector/FuncCall/VersionCompareFuncCallToConstantRector.php
@@ -113,9 +113,7 @@ public function refactor(Node $node): ?Node
 
         /** @var Arg[] $args */
         $args = $node->args;
-        if (! $this->isPhpVersionConstant($args[0]->value) && ! $this->isPhpVersionConstant(
-            $args[1]->value
-        )) {
+        if (! $this->isPhpVersionConstant($args[0]->value) && ! $this->isPhpVersionConstant($args[1]->value)) {
             return null;
         }
 

diff --git a/rules/DowngradePhp73/Rector/FuncCall/SetCookieOptionsArrayToArgumentsRector.php b/rules/DowngradePhp73/Rector/FuncCall/SetCookieOptionsArrayToArgumentsRector.php
@@ -48,6 +48,11 @@ final class SetCookieOptionsArrayToArgumentsRector extends AbstractRector
 
     private int $highestIndex = 1;
 
+    public function __construct(
+        private ArgsAnalyzer $argsAnalyzer
+    ) {
+    }
+
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
@@ -66,10 +71,6 @@ public function getRuleDefinition(): RuleDefinition
         );
     }
 
-    public function __construct(private ArgsAnalyzer $argsAnalyzer)
-    {
-    }
-
     /**
      * @return array<class-string<Node>>
      */

diff --git a/rules/MysqlToMysqli/Rector/FuncCall/MysqlFuncCallToMysqliRector.php b/rules/MysqlToMysqli/Rector/FuncCall/MysqlFuncCallToMysqliRector.php
@@ -71,7 +71,10 @@ public function refactor(Node $node): ?FuncCall
             $node->args[0] = new Arg(new String_('SHOW DATABASES'));
         }
 
-        if ($this->isName($node, 'mysql_list_fields') && $node->args[0] instanceof Arg && $node->args[1] instanceof Arg) {
+        if ($this->isName(
+            $node,
+            'mysql_list_fields'
+        ) && $node->args[0] instanceof Arg && $node->args[1] instanceof Arg) {
             $node->name = new Name(self::MYSQLI_QUERY);
             $node->args[0]->value = $this->joinStringWithNode('SHOW COLUMNS FROM', $node->args[1]->value);
 

diff --git a/rules/Php56/Rector/FuncCall/PowToExpRector.php b/rules/Php56/Rector/FuncCall/PowToExpRector.php
@@ -20,8 +20,9 @@
  */
 final class PowToExpRector extends AbstractRector implements MinPhpVersionInterface
 {
-    public function __construct(private ArgsAnalyzer $argsAnalyzer)
-    {
+    public function __construct(
+        private ArgsAnalyzer $argsAnalyzer
+    ) {
     }
 
     public function getRuleDefinition(): RuleDefinition
@@ -62,7 +63,7 @@ public function refactor(Node $node): ?Node
         /** @var Arg $secondArgument */
         $secondArgument = $node->args[1];
 
-        return new Pow($firstArgument->value,  $secondArgument->value);
+        return new Pow($firstArgument->value, $secondArgument->value);
     }
 
     public function provideMinPhpVersion(): int

diff --git a/rules/Php70/Rector/FuncCall/EregToPregMatchRector.php b/rules/Php70/Rector/FuncCall/EregToPregMatchRector.php
@@ -70,20 +70,6 @@ public function getNodeTypes(): array
         return [FuncCall::class];
     }
 
-    private function shouldSkip(FuncCall $funcCall): bool
-    {
-        $functionName = $this->getName($funcCall);
-        if ($functionName === null) {
-            return true;
-        }
-
-        if (! isset(self::OLD_NAMES_TO_NEW_ONES[$functionName])) {
-            return true;
-        }
-
-        return ! $this->argsAnalyzer->isArgInstanceInArgsPosition($funcCall->args, 0);
-    }
-
     /**
      * @param FuncCall $node
      */
@@ -109,7 +95,11 @@ public function refactor(Node $node): ?Node
         $node->name = new Name(self::OLD_NAMES_TO_NEW_ONES[$functionName]);
 
         // ereg|eregi 3rd argument return value fix
-        if (in_array($functionName, ['ereg', 'eregi'], true) && isset($node->args[2]) && $node->args[2] instanceof Arg) {
+        if (in_array(
+            $functionName,
+            ['ereg', 'eregi'],
+            true
+        ) && isset($node->args[2]) && $node->args[2] instanceof Arg) {
             $parentNode = $node->getAttribute(AttributeKey::PARENT_NODE);
             if ($parentNode instanceof Assign) {
                 return $this->createTernaryWithStrlenOfFirstMatch($node);
@@ -119,6 +109,20 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
+    private function shouldSkip(FuncCall $funcCall): bool
+    {
+        $functionName = $this->getName($funcCall);
+        if ($functionName === null) {
+            return true;
+        }
+
+        if (! isset(self::OLD_NAMES_TO_NEW_ONES[$functionName])) {
+            return true;
+        }
+
+        return ! $this->argsAnalyzer->isArgInstanceInArgsPosition($funcCall->args, 0);
+    }
+
     private function processStringPattern(FuncCall $funcCall, String_ $string, string $functionName): void
     {
         $pattern = $string->value;

diff --git a/rules/Php74/Rector/StaticCall/ExportToReflectionFunctionRector.php b/rules/Php74/Rector/StaticCall/ExportToReflectionFunctionRector.php
@@ -25,8 +25,9 @@
  */
 final class ExportToReflectionFunctionRector extends AbstractRector implements MinPhpVersionInterface
 {
-    public function __construct(private ArgsAnalyzer $argsAnalyzer)
-    {
+    public function __construct(
+        private ArgsAnalyzer $argsAnalyzer
+    ) {
     }
 
     public function provideMinPhpVersion(): int

diff --git a/rules/Php80/Rector/ClassMethod/OptionalParametersAfterRequiredRector.php b/rules/Php80/Rector/ClassMethod/OptionalParametersAfterRequiredRector.php
@@ -162,7 +162,10 @@ private function refactorMethodCall(MethodCall $methodCall): ?MethodCall
             return null;
         }
 
-        $expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($methodReflection, $methodCall->getArgs());
+        $expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent(
+            $methodReflection,
+            $methodCall->getArgs()
+        );
         if ($expectedArgOrParamOrder === null) {
             return null;
         }

diff --git a/rules/Php80/ValueObjectFactory/StrStartsWithFactory.php b/rules/Php80/ValueObjectFactory/StrStartsWithFactory.php
@@ -11,8 +11,9 @@
 
 final class StrStartsWithFactory
 {
-    public function __construct(private ArgsAnalyzer $argsAnalyzer)
-    {
+    public function __construct(
+        private ArgsAnalyzer $argsAnalyzer
+    ) {
     }
 
     public function createFromFuncCall(FuncCall $funcCall, bool $isPositive): ?StrStartsWith