[CodingStyle] Remove custom code rule ManualJsonStringToJsonEncodeArr…

…ayRector, not much generic (#1398) * [CodingStyle] Remove custom code rule ManualJsonStringToJsonEncodeArrayRector, not much generic * remove rule from doc
rectorphp · Dec 5, 2021 · 29562a6 · 29562a6
1 parent f99d879
commit 29562a6
Show file tree

Hide file tree

Showing 24 changed files with 2 additions and 1,127 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
@@ -1,4 +1,4 @@
-# 504 Rules Overview
+# 503 Rules Overview
 
 <br>
 
@@ -12,7 +12,7 @@
 
 - [CodeQuality](#codequality) (70)
 
-- [CodingStyle](#codingstyle) (37)
+- [CodingStyle](#codingstyle) (36)
 
 - [Compatibility](#compatibility) (1)
 
@@ -2130,31 +2130,6 @@ Make method visibility same as parent one
 
 <br>
 
-### ManualJsonStringToJsonEncodeArrayRector
-
-Convert manual JSON string to JSON::encode array
-
-- class: [`Rector\CodingStyle\Rector\Assign\ManualJsonStringToJsonEncodeArrayRector`](../rules/CodingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector.php)
-
-```diff
-+use Nette\Utils\Json;
-+
- final class SomeClass
- {
-     public function run()
-     {
--        $someJsonAsString = '{"role_name":"admin","numberz":{"id":"10"}}';
-+        $data = [
-+            'role_name' => 'admin',
-+            'numberz' => ['id' => 10]
-+        ];
-+        $someJsonAsString = Json::encode($data);
-     }
- }
-```
-
-<br>
-
 ### NewlineAfterStatementRector
 
 Add new line after statements to tidify code

diff --git a/config/set/coding-style.php b/config/set/coding-style.php
@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-use Rector\CodingStyle\Rector\Assign\ManualJsonStringToJsonEncodeArrayRector;
 use Rector\CodingStyle\Rector\Assign\PHPStormVarAnnotationRector;
 use Rector\CodingStyle\Rector\Assign\SplitDoubleAssignRector;
 use Rector\CodingStyle\Rector\Catch_\CatchExceptionNameMatchingTypeRector;
@@ -55,7 +54,6 @@
     $services->set(EncapsedStringsToSprintfRector::class);
     $services->set(WrapEncapsedVariableInCurlyBracesRector::class);
     $services->set(NewlineBeforeNewAssignSetRector::class);
-    $services->set(ManualJsonStringToJsonEncodeArrayRector::class);
     $services->set(AddArrayDefaultToArrayPropertyRector::class);
     $services->set(AddFalseDefaultToBoolPropertyRector::class);
     $services->set(MakeInheritedMethodVisibilitySameAsParentRector::class);

diff --git a/phpstan.neon b/phpstan.neon
@@ -413,7 +413,6 @@ parameters:
             paths:
                 - packages/NodeNestingScope/FlowOfControlLocator.php
                 - rules/CodeQuality/Rector/Return_/SimplifyUselessVariableRector.php
-                - rules/CodingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector.php
                 - rules/Php70/Rector/FuncCall/MultiDirnameRector.php
                 - src/Application/FileProcessor.php
                 - src/PhpParser/Node/BetterNodeFinder.php

diff --git a/...gStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/array_concat.php.inc b/...gStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/array_concat.php.inc
diff --git a/.../Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/assign_with_concat.php.inc b/.../Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/assign_with_concat.php.inc
diff --git a/...ngStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/concat_json.php.inc b/...ngStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/concat_json.php.inc
diff --git a/...CodingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/fixture.php.inc b/...CodingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/fixture.php.inc
diff --git a/...ctor/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/multiline_concat_json.php.inc b/...ctor/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/multiline_concat_json.php.inc
diff --git a/...dingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/null_item.php.inc b/...dingStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/null_item.php.inc
diff --git a/...tor/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/simple_row_with_spaces.php.inc b/...tor/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/simple_row_with_spaces.php.inc
diff --git a/.../ManualJsonStringToJsonEncodeArrayRector/Fixture/tripleline_multiline_concat_json.php.inc b/.../ManualJsonStringToJsonEncodeArrayRector/Fixture/tripleline_multiline_concat_json.php.inc
diff --git a/...gStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/with_implode.php.inc b/...gStyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/with_implode.php.inc
diff --git a/...tyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/without_assign.php.inc b/...tyle/Rector/Assign/ManualJsonStringToJsonEncodeArrayRector/Fixture/without_assign.php.inc