[Php81] Skip always string if else DomElement on NullToStrictStringFu…

…ncCallArgRector (#5822)

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_always_string_if_else_dom_element.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+final class SkipAlwaysStringIfElseDomElement {
+    public function getTitle(string $html): string {
+        $dom = new \DOMDocument();
+        $dom->loadHTML($html);
+        $titleElement = $dom->getElementsByTagName('title')->item(0);
+        if ($titleElement?->nodeValue !== null) {
+            return trim($titleElement->nodeValue);
+        } else {
+            return 'Unnamed document';
+        }
+    }
+}

rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php

@@ -199,7 +199,7 @@ private function processNullToStrictStringOnNodePosition(
             return null;
         }
 
-        if ($this->isAnErrorTypeFromParentScope($argValue, $scope)) {
+        if ($this->isAnErrorType($argValue, $nativeType, $scope)) {
             return null;
         }
 
@@ -251,10 +251,6 @@ private function shouldSkipTrait(Expr $expr, Type $type, bool $isTrait): bool
             return false;
         }
 
-        if ($type instanceof ErrorType) {
-            return true;
-        }
-
         if ($type->isExplicitMixed()) {
             return false;
         }
@@ -266,8 +262,12 @@ private function shouldSkipTrait(Expr $expr, Type $type, bool $isTrait): bool
         return true;
     }
 
-    private function isAnErrorTypeFromParentScope(Expr $expr, Scope $scope): bool
+    private function isAnErrorType(Expr $expr, Type $type, Scope $scope): bool
     {
+        if ($type instanceof ErrorType) {
+            return true;
+        }
+
         $parentScope = $scope->getParentScope();
         if ($parentScope instanceof Scope) {
             return $parentScope->getType($expr) instanceof ErrorType;