Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php81] Skip always string if else DomElement on NullToStrictStringFuncCallArgRector #5822

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[Php81] Skip always string if else DomElement on NullToStrictStringFuncCallArgRector #5822

merged 1 commit into from
Apr 15, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 15, 2024 •
edited

The native type is detected as ErrorType, so skip the ErrorType when detected.

Fixes rectorphp/rector#8597

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @jlherren

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 2b811af into main Apr 15, 2024
42 checks passed
@samsonasik samsonasik deleted the skip-always-string-dom-element branch April 15, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@samsonasik