Make relativeFilePathFromDirectory() private as used only locally (#4735

)

src/FileSystem/FilePathHelper.php

@@ -44,20 +44,6 @@ public function relativePath(string $fileRealPath): string
         return $this->relativeFilePathFromDirectory($fileRealPath, getcwd());
     }
 
-    /**
-     * @api
-     */
-    public function relativeFilePathFromDirectory(string $fileRealPath, string $directory): string
-    {
-        Assert::directory($directory);
-
-        $normalizedFileRealPath = $this->normalizePath($fileRealPath);
-
-        $relativeFilePath = $this->filesystem->makePathRelative($normalizedFileRealPath, $directory);
-
-        return rtrim($relativeFilePath, '/');
-    }
-
     /**
      * Used from
      * https://github.com/phpstan/phpstan-src/blob/02425e61aa48f0668b4efb3e73d52ad544048f65/src/File/FileHelper.php#L40, with custom modifications
@@ -86,6 +72,15 @@ public function normalizePathAndSchema(string $originalPath): string
         return $pathStart . $pathRoot . implode($directorySeparator, $normalizedPathParts);
     }
 
+    private function relativeFilePathFromDirectory(string $fileRealPath, string $directory): string
+    {
+        Assert::directory($directory);
+        $normalizedFileRealPath = $this->normalizePath($fileRealPath);
+
+        $relativeFilePath = $this->filesystem->makePathRelative($normalizedFileRealPath, $directory);
+        return rtrim($relativeFilePath, '/');
+    }
+
     private function normalizePath(string $filePath): string
     {
         return \str_replace('\\', '/', $filePath);

src/PhpParser/NodeTraverser/RectorNodeTraverser.php

@@ -42,6 +42,17 @@ public function traverse(array $nodes): array
         return parent::traverse($nodes);
     }
 
+    /**
+     * @api used in tests to update the active rules
+     * @param PhpRectorInterface[] $phpRectors
+     */
+    public function refreshPhpRectors(array $phpRectors): void
+    {
+        $this->phpRectors = $phpRectors;
+        $this->visitors = [];
+        $this->areNodeVisitorsPrepared = false;
+    }
+
     /**
      * This must happen after $this->configuration is set after ProcessCommand::execute() is run,
      * otherwise we get default false positives.