fix casing of enums

rectorphp · Jun 13, 2022 · 332aad3 · 332aad3
1 parent 6f164da
commit 332aad3
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 13 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
@@ -8724,9 +8724,9 @@ Refactor Spatie enum class to native Enum
 -class StatusEnum extends Enum
 +enum StatusEnum : string
  {
-+    case draft = 'draft';
-+    case published = 'published';
-+    case archived = 'archived';
++    case DRAFT = 'draft';
++    case PUBLISHED = 'published';
++    case ARCHIVED = 'archived';
  }
 ```
 

diff --git a/rules-tests/Php81/Rector/Class_/SpatieEnumClassToEnumRector/Fixture/some_class.php.inc b/rules-tests/Php81/Rector/Class_/SpatieEnumClassToEnumRector/Fixture/some_class.php.inc
@@ -23,9 +23,9 @@ use Spatie\Enum\Enum;
 
 enum StatusEnum : string
 {
-    case draft = 'draft';
-    case published = 'published';
-    case archived = 'archived';
+    case DRAFT = 'draft';
+    case PUBLISHED = 'published';
+    case ARCHIVED = 'archived';
 }
 
 ?>
diff --git a/rules/Php81/NodeFactory/EnumFactory.php b/rules/Php81/NodeFactory/EnumFactory.php
@@ -55,10 +55,10 @@ public function createFromSpatieClass(Class_ $class): Enum_
         $enum = new Enum_($shortClassName);
 
         // constant to cases
-        $phpDocInfo = $this->phpDocInfoFactory->createFromNode($class);
+        $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($class);
 
-        $docBlockMethods = $phpDocInfo?->getTagsByName('@method');
-        if ($docBlockMethods !== null) {
+        $docBlockMethods = $phpDocInfo->getTagsByName('@method');
+        if ($docBlockMethods !== []) {
             $enum->scalarType = new Identifier('string');
 
             foreach ($docBlockMethods as $docBlockMethod) {
@@ -85,6 +85,10 @@ private function createEnumCaseFromDocComment(PhpDocTagNode $phpDocTagNode): Enu
     {
         /** @var MethodTagValueNode $nodeValue */
         $nodeValue = $phpDocTagNode->value;
-        return new EnumCase($nodeValue->methodName, $this->builderFactory->val($nodeValue->methodName));
+
+        $enumName = strtoupper($nodeValue->methodName);
+        $enumExpr = $this->builderFactory->val($nodeValue->methodName);
+
+        return new EnumCase($enumName, $enumExpr);
     }
 }
diff --git a/rules/Php81/Rector/Class_/SpatieEnumClassToEnumRector.php b/rules/Php81/Rector/Class_/SpatieEnumClassToEnumRector.php
@@ -54,9 +54,9 @@ class StatusEnum extends Enum
                 <<<'CODE_SAMPLE'
 enum StatusEnum : string
 {
-    case draft = 'draft';
-    case published = 'published';
-    case archived = 'archived';
+    case DRAFT = 'draft';
+    case PUBLISHED = 'published';
+    case ARCHIVED = 'archived';
 }
 CODE_SAMPLE
             ),