[Php83] Early check private method in child before check parent on Ad…

…dOverrideAttributeToOverriddenMethodsRector (#5622) * [Php83] Early check private method in child before check parent on AddOverrideAttributeToOverriddenMethodsRector * [Php83] Early check private method in child before check parent on AddOverrideAttributeToOverriddenMethodsRector
rectorphp · Feb 16, 2024 · 39d9c32 · 39d9c32
1 parent c4dd05e
commit 39d9c32
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/...sMethod/AddOverrideAttributeToOverriddenMethodsRector/Fixture/skip_private_method.php.inc b/...sMethod/AddOverrideAttributeToOverriddenMethodsRector/Fixture/skip_private_method.php.inc
@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector\Fixture;
+
+use Rector\Tests\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector\Source\ExampleParentClass;
+
+class SkipPrivateMethod extends ExampleParentClass
+{
+    private function bar()
+    {
+    }
+}
+
+?>
diff --git a/rules/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector.php b/rules/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector.php
@@ -132,6 +132,10 @@ private function processAddOverrideAttribute(Class_ $class, array $parentClassRe
                 continue;
             }
 
+            if ($classMethod->isPrivate()) {
+                continue;
+            }
+
             // ignore if it already uses the attribute
             if ($this->phpAttributeAnalyzer->hasPhpAttribute($classMethod, 'Override')) {
                 continue;