New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php83] Early check private method in child before check parent on AddOverrideAttributeToOverriddenMethodsRector #5622

Merged

samsonasik merged 2 commits into main from early-check-private

Feb 16, 2024

Member

samsonasik commented Feb 16, 2024

No need to loop parent ancestors when method already private, see https://3v4l.org/v0Cs8#v8.3.3

samsonasik added 2 commits

February 16, 2024 21:35


          [Php83] Early check private method in child before check parent on Ad…

273e207

…dOverrideAttributeToOverriddenMethodsRector


          [Php83] Early check private method in child before check parent on Ad…

754be75

…dOverrideAttributeToOverriddenMethodsRector

Member Author

samsonasik commented Feb 16, 2024

All checks have passed 🎉 @TomasVotruba I am merging it ;)

samsonasik merged commit 39d9c32 into main

41 checks passed

samsonasik deleted the early-check-private branch

February 16, 2024 14:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment