[DX] Remove DependencyClassMethodDecorator as not used anymore due to…

… paralel nature (#5094)
rectorphp · Sep 30, 2023 · 3c1035b · 3c1035b
1 parent 6ce58b1
commit 3c1035b
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 291 deletions.
diff --git a/packages/NodeNameResolver/NodeNameResolver.php b/packages/NodeNameResolver/NodeNameResolver.php
@@ -144,6 +144,9 @@ public function getName(Node | string $node): ?string
         return (string) $node->name;
     }
 
+    /**
+     * @api
+     */
     public function areNamesEqual(Node $firstNode, Node $secondNode): bool
     {
         $secondResolvedName = $this->getName($secondNode);

diff --git a/src/Configuration/RenamedClassesDataCollector.php b/src/Configuration/RenamedClassesDataCollector.php
@@ -14,9 +14,6 @@ final class RenamedClassesDataCollector implements ResetableInterface
      */
     private array $oldToNewClasses = [];
 
-    /**
-     * @api for fast tests with single container
-     */
     public function reset(): void
     {
         $this->oldToNewClasses = [];

diff --git a/src/Exception/DeprecatedException.php b/src/Exception/DeprecatedException.php
diff --git a/src/NodeAnalyzer/PromotedPropertyParamCleaner.php b/src/NodeAnalyzer/PromotedPropertyParamCleaner.php
diff --git a/src/NodeManipulator/ClassDependencyManipulator.php b/src/NodeManipulator/ClassDependencyManipulator.php
@@ -12,19 +12,16 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Property;
-use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Type\Type;
 use Rector\Core\Enum\ObjectReference;
 use Rector\Core\NodeAnalyzer\PropertyPresenceChecker;
-use Rector\Core\NodeManipulator\Dependency\DependencyClassMethodDecorator;
 use Rector\Core\Php\PhpVersionProvider;
 use Rector\Core\PhpParser\Node\NodeFactory;
 use Rector\Core\Reflection\ReflectionResolver;
 use Rector\Core\ValueObject\MethodName;
 use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\NodeNameResolver\NodeNameResolver;
-use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PostRector\ValueObject\PropertyMetadata;
 use Rector\TypeDeclaration\NodeAnalyzer\AutowiredClassMethodOrPropertyAnalyzer;
 
@@ -39,7 +36,6 @@ public function __construct(
         private readonly PropertyPresenceChecker $propertyPresenceChecker,
         private readonly NodeNameResolver $nodeNameResolver,
         private readonly AutowiredClassMethodOrPropertyAnalyzer $autowiredClassMethodOrPropertyAnalyzer,
-        private readonly DependencyClassMethodDecorator $dependencyClassMethodDecorator,
         private readonly ReflectionResolver $reflectionResolver
     ) {
     }
@@ -98,15 +94,6 @@ public function addConstructorDependencyWithCustomAssign(
 
         $this->classMethodAssignManipulator->addParameterAndAssignToMethod($constructorMethod, $name, $type, $assign);
         $this->classInsertManipulator->addAsFirstMethod($class, $constructorMethod);
-
-        /** @var Scope $scope */
-        $scope = $class->getAttribute(AttributeKey::SCOPE);
-
-        $this->dependencyClassMethodDecorator->decorateConstructorWithParentDependencies(
-            $class,
-            $constructorMethod,
-            $scope
-        );
     }
 
     /**
@@ -157,15 +144,6 @@ private function addPromotedProperty(Class_ $class, PropertyMetadata $propertyMe
             $constructClassMethod = $this->nodeFactory->createPublicMethod(MethodName::CONSTRUCT);
             $constructClassMethod->params[] = $param;
             $this->classInsertManipulator->addAsFirstMethod($class, $constructClassMethod);
-
-            /** @var Scope $scope */
-            $scope = $class->getAttribute(AttributeKey::SCOPE);
-
-            $this->dependencyClassMethodDecorator->decorateConstructorWithParentDependencies(
-                $class,
-                $constructClassMethod,
-                $scope
-            );
         }
     }
 

diff --git a/src/NodeManipulator/Dependency/DependencyClassMethodDecorator.php b/src/NodeManipulator/Dependency/DependencyClassMethodDecorator.php
diff --git a/src/PhpParser/Node/NodeFactory.php b/src/PhpParser/Node/NodeFactory.php
@@ -43,7 +43,6 @@
 use Rector\Core\Exception\NotImplementedYetException;
 use Rector\Core\Exception\ShouldNotHappenException;
 use Rector\Core\NodeDecorator\PropertyTypeDecorator;
-use Rector\Core\ValueObject\MethodName;
 use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
 use Rector\PostRector\ValueObject\PropertyMetadata;
 use Rector\StaticTypeMapper\StaticTypeMapper;
@@ -197,18 +196,6 @@ public function createPropertyFetch(string | Expr $variableNameOrExpr, string $p
         return $this->builderFactory->propertyFetch($fetcherExpr, $property);
     }
 
-    /**
-     * @param Param[] $params
-     */
-    public function createParentConstructWithParams(array $params): StaticCall
-    {
-        return new StaticCall(
-            new Name(ObjectReference::PARENT),
-            new Identifier(MethodName::CONSTRUCT),
-            $this->createArgsFromParams($params)
-        );
-    }
-
     /**
      * @api doctrine
      */