Remove AddPregQuoteDelimiterRector as very narrow area and has not co…

…ntext awareness, better handle manually (#3927)
rectorphp · May 22, 2023 · 3c69a0f · 3c69a0f
1 parent 79ffda7
commit 3c69a0f
Show file tree

Hide file tree

Showing 9 changed files with 2 additions and 262 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
@@ -1,12 +1,12 @@
-# 403 Rules Overview
+# 402 Rules Overview
 
 <br>
 
 ## Categories
 
 - [Arguments](#arguments) (6)
 
-- [CodeQuality](#codequality) (76)
+- [CodeQuality](#codequality) (75)
 
 - [CodingStyle](#codingstyle) (34)
 
@@ -328,19 +328,6 @@ include/require to absolute path. This Rector might introduce backwards incompat
 
 <br>
 
-### AddPregQuoteDelimiterRector
-
-Add preg_quote delimiter when missing
-
-- class: [`Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector`](../rules/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector.php)
-
-```diff
--'#' . preg_quote('name') . '#';
-+'#' . preg_quote('name', '#') . '#';
-```
-
-<br>
-
 ### AndAssignsToSeparateLinesRector
 
 Split 2 assigns ands to separate line

diff --git a/config/set/code-quality.php b/config/set/code-quality.php
@@ -24,7 +24,6 @@
 use Rector\CodeQuality\Rector\Foreach_\SimplifyForeachToArrayFilterRector;
 use Rector\CodeQuality\Rector\Foreach_\SimplifyForeachToCoalescingRector;
 use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector;
-use Rector\CodeQuality\Rector\FuncCall\AddPregQuoteDelimiterRector;
 use Rector\CodeQuality\Rector\FuncCall\ArrayKeysAndInArrayToArrayKeyExistsRector;
 use Rector\CodeQuality\Rector\FuncCall\ArrayMergeOfNonArraysToSimpleArrayRector;
 use Rector\CodeQuality\Rector\FuncCall\BoolvalToTypeCastRector;
@@ -155,7 +154,6 @@
         ThrowWithPreviousExceptionRector::class,
         RemoveSoleValueSprintfRector::class,
         ShortenElseIfRector::class,
-        AddPregQuoteDelimiterRector::class,
         ArrayMergeOfNonArraysToSimpleArrayRector::class,
         IntvalToTypeCastRector::class,
         BoolvalToTypeCastRector::class,

diff --git a/...deQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/AddPregQuoteDelimiterRectorTest.php b/...deQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/AddPregQuoteDelimiterRectorTest.php
diff --git a/rules-tests/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/Fixture/fixture.php.inc b/rules-tests/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/Fixture/fixture.php.inc
diff --git a/rules-tests/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/Fixture/skip.php.inc b/rules-tests/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/Fixture/skip.php.inc
diff --git a/...uality/Rector/FuncCall/AddPregQuoteDelimiterRector/Fixture/skip_unknown_delimiter.php.inc b/...uality/Rector/FuncCall/AddPregQuoteDelimiterRector/Fixture/skip_unknown_delimiter.php.inc
diff --git a/...ts/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/Fixture/with_modifiers.php.inc b/...ts/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/Fixture/with_modifiers.php.inc
diff --git a/...-tests/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/config/configured_rule.php b/...-tests/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector/config/configured_rule.php
diff --git a/rules/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector.php b/rules/CodeQuality/Rector/FuncCall/AddPregQuoteDelimiterRector.php