[DowngradePhp80] Skip remove self on DowngradeStaticTypeDeclarationRe…

…ctor (#721) Co-authored-by: Brandon Olivares <programmer2188@gmail.com>
rectorphp · Aug 20, 2021 · 3c8f8a0 · 3c8f8a0
1 parent 998029d
commit 3c8f8a0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/...dePhp80/Rector/ClassMethod/DowngradeStaticTypeDeclarationRector/Fixture/skip_self.php.inc b/...dePhp80/Rector/ClassMethod/DowngradeStaticTypeDeclarationRector/Fixture/skip_self.php.inc
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DowngradePhp80\Rector\ClassMethod\DowngradeStaticTypeDeclarationRector\Fixture;
+
+final class SkipSelf
+{
+    public function run(): self
+    {
+        return $this;
+    }
+}
diff --git a/rules/DowngradePhp80/Rector/ClassMethod/DowngradeStaticTypeDeclarationRector.php b/rules/DowngradePhp80/Rector/ClassMethod/DowngradeStaticTypeDeclarationRector.php
@@ -5,6 +5,7 @@
 namespace Rector\DowngradePhp80\Rector\ClassMethod;
 
 use PhpParser\Node;
+use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ReflectionProvider;
@@ -72,6 +73,13 @@ public function getStatic()
      */
     public function refactor(Node $node): ?Node
     {
+        if ($node->returnType instanceof Name && $this->nodeNameResolver->isName(
+            $node->returnType,
+            'self'
+        )) {
+            return null;
+        }
+
         $scope = $node->getAttribute(AttributeKey::SCOPE);
         if ($scope === null) {
             $className = $node->getAttribute(AttributeKey::CLASS_NAME);