Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DowngradePhp80] Skip remove self on DowngradeStaticTypeDeclarationRector #721

Merged
merged 5 commits into from
Aug 20, 2021
Merged

[DowngradePhp80] Skip remove self on DowngradeStaticTypeDeclarationRector #721

merged 5 commits into from
Aug 20, 2021

Conversation

samsonasik
Copy link
Member

Closes #720

@samsonasik samsonasik mentioned this pull request Aug 20, 2021
Closed
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit 3c8f8a0 into main Aug 20, 2021
@TomasVotruba TomasVotruba deleted the DowngradeStaticTypeDeclarationRector-removes-self-return-type branch August 20, 2021 10:27
@samsonasik
Copy link
Member Author

It seems it somehow cause error on scoper builds

https://github.com/rectorphp/rector/runs/3382501532

@samsonasik samsonasik mentioned this pull request Aug 20, 2021
Closed
@samsonasik
Copy link
Member Author

Fixed 🎉 🎉 🎉

Screen Shot 2021-08-21 at 00 59 26

rectorphp/rector@056fee1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @TomasVotruba @devbanana