Deprecate CountOnNullRector as depends on previous context and requir…

…e manual adjustment of previous result (#5101)

config/set/php71.php

@@ -7,18 +7,18 @@
 use Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector;
 use Rector\Php71\Rector\BooleanOr\IsIterableRector;
 use Rector\Php71\Rector\ClassConst\PublicConstantVisibilityRector;
-use Rector\Php71\Rector\FuncCall\CountOnNullRector;
 use Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector;
 use Rector\Php71\Rector\List_\ListToArrayDestructRector;
 use Rector\Php71\Rector\TryCatch\MultiExceptionCatchRector;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(IsIterableRector::class);
-    $rectorConfig->rule(MultiExceptionCatchRector::class);
-    $rectorConfig->rule(AssignArrayToStringRector::class);
-    $rectorConfig->rule(CountOnNullRector::class);
-    $rectorConfig->rule(RemoveExtraParametersRector::class);
-    $rectorConfig->rule(BinaryOpBetweenNumberAndStringRector::class);
-    $rectorConfig->rule(ListToArrayDestructRector::class);
-    $rectorConfig->rule(PublicConstantVisibilityRector::class);
+    $rectorConfig->rules([
+        IsIterableRector::class,
+        MultiExceptionCatchRector::class,
+        AssignArrayToStringRector::class,
+        RemoveExtraParametersRector::class,
+        BinaryOpBetweenNumberAndStringRector::class,
+        ListToArrayDestructRector::class,
+        PublicConstantVisibilityRector::class,
+    ]);
 };

phpstan.neon

@@ -458,7 +458,6 @@ parameters:
         - '#Doing instanceof PHPStan\\Type\\.* is error\-prone and deprecated(\. Use Type\:\:.*\(\) (or .* )?instead)?#'
 
         # phpstan 1.10.0
-        - '#Call to deprecated method getDirectClassNames\(\) of class PHPStan\\Type\\TypeUtils.*#'
         - '#Parameter 3 should use "PHPStan\\Reflection\\ParameterReflectionWithPhpDocs" type as the only type passed to this method#'
 
         # false positive on enums
@@ -567,7 +566,10 @@ parameters:
                 - rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorReadonlyClassRector.php
                 - rules/CodingStyle/Rector/Switch_/BinarySwitchToIfElseRector.php
 
+        # deprecated
         - '#Fetching class constant class of deprecated class Rector\\TypeDeclaration\\Rector\\Property\\TypedPropertyFromStrictConstructorReadonlyClassRector#'
+        - '#Class "Rector\\Php71\\Rector\\FuncCall\\CountOnNullRector" is missing @see annotation with test case class reference#'
+        - '#Register "Rector\\Php71\\Rector\\FuncCall\\CountOnNullRector" service to "php71\.php" config set#'
 
         # dev rule
         - '#Class "Rector\\Utils\\Rector\\MoveAbstractRectorToChildrenRector" is missing @see annotation with test case class reference#'