[Core] Fix crash indentation on indent(\t, 1) config (#3155)

src/PhpParser/Printer/BetterStandardPrinter.php

@@ -93,6 +93,8 @@ public function __construct(
         $this->insertionMap['Stmt_Function->returnType'] = [')', false, ': ', null];
         $this->insertionMap['Expr_Closure->returnType'] = [')', false, ': ', null];
         $this->insertionMap['Expr_ArrowFunction->returnType'] = [')', false, ': ', null];
+
+        $this->tabOrSpaceIndentCharacter = $this->rectorConfigProvider->getIndentChar();
     }
 
     /**
@@ -104,8 +106,6 @@ public function printFormatPreserving(array $stmts, array $origStmts, array $ori
     {
         $newStmts = $this->resolveNewStmts($stmts);
 
-        $this->tabOrSpaceIndentCharacter = $this->rectorConfigProvider->getIndentChar();
-
         $content = parent::printFormatPreserving($newStmts, $origStmts, $origTokens);
 
         // add new line in case of added stmts

tests/Issues/IndentationCrash/FixtureTab/if_else_tab_indentation.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Core\Tests\Issues\IndentationCrash\FixtureTab;
+
+final class IfElseTabIndentation
+{
+	/**
+	 * @param string[]|string $args
+	 *
+	 * @return void
+	 */
+	public function run( $args ) {
+		if ( is_array( $args ) ) {
+			foreach ( $args as $data ) {
+				echo $data;
+			}
+		} else {
+			echo $args;
+		}
+	}
+}

tests/Issues/IndentationCrash/TabIndentationCrashTest.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\IndentationCrash;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class TabIndentationCrashTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    /**
+     * @return Iterator<array<string>>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/FixtureTab');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/tab_configured_rule.php';
+    }
+}

tests/Issues/IndentationCrash/config/tab_configured_rule.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\If_\SimplifyIfElseWithSameContentRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->indent("\t", 1);
+    $rectorConfig->rule(SimplifyIfElseWithSameContentRector::class);
+};