Skip short class names in UseClassKeywordForClassNameResolutionRector (…

…#3156)

Co-authored-by: GitHub Action <action@github.com>

phpstan.neon

@@ -647,10 +647,12 @@ parameters:
 
         - '#Call to static method Webmozart\\Assert\\Assert\:\:allString\(\) with array<string> will always evaluate to true#'
 
-        # simple filter
+        # simple array filters
         -
             message: '#Use separate function calls with readable variable names#'
-            path: utils/RuleDocGenerator/PostRectorOutFilter.php
+            paths:
+                - utils/RuleDocGenerator/PostRectorOutFilter.php
+                - rules/CodingStyle/Rector/String_/UseClassKeywordForClassNameResolutionRector.php
 
         # phpdoc node traversing
         -

rules-tests/CodingStyle/Rector/String_/UseClassKeywordForClassNameResolutionRector/Fixture/skip_a_closure.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\String_\UseClassKeywordForClassNameResolutionRector\Fixture;
+
+final class SkipAClosure
+{
+    public function run()
+    {
+        return 'Some Closure::needs() to be done';
+    }
+}

rules/CodingStyle/Rector/String_/UseClassKeywordForClassNameResolutionRector.php

@@ -68,8 +68,10 @@ public function refactor(Node $node): ?Node
         }
 
         $classNames = $this->getExistingClasses($node);
+        $classNames = $this->filterOurShortClasses($classNames);
+
         if ($classNames === []) {
-            return $node;
+            return null;
         }
 
         $parts = $this->getParts($node, $classNames);
@@ -136,4 +138,13 @@ private function createExpressionsToConcat(array $parts): array
 
         return $exprsToConcat;
     }
+
+    /**
+     * @param string[] $classNames
+     * @return string[]
+     */
+    private function filterOurShortClasses(array $classNames): array
+    {
+        return array_filter($classNames, static fn (string $className): bool => str_contains($className, '\\'));
+    }
 }