[DeadCode] RemoveDeadZeroAndOneOperationRector should not remove Cons…

…tants (#4910)

rules-tests/DeadCode/Rector/Plus/RemoveDeadZeroAndOneOperationRector/Fixture/skip_constants.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Plus\RemoveDeadZeroAndOneOperationRector\Fixture;
+
+class SkipConstants
+{
+    public const ONE = 1;
+
+    public function run()
+    {
+        $value = 5 * self::ONE;
+        $value = 5 / self::ONE;
+        $value = self::ONE * 5;
+        $value = self::ONE / 5;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Plus\RemoveDeadZeroAndOneOperationRector\Fixture;
+
+class SkipConstants
+{
+    public const ONE = 1;
+
+    public function run()
+    {
+        $value = 5 * self::ONE;
+        $value = 5 / self::ONE;
+        $value = self::ONE * 5;
+        $value = self::ONE / 5;
+    }
+}
+
+?>

rules/DeadCode/Rector/Plus/RemoveDeadZeroAndOneOperationRector.php

@@ -16,6 +16,7 @@
 use PhpParser\Node\Expr\BinaryOp\Minus;
 use PhpParser\Node\Expr\BinaryOp\Mul;
 use PhpParser\Node\Expr\BinaryOp\Plus;
+use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Expr\UnaryMinus;
 use Rector\Core\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -169,6 +170,10 @@ private function processBinaryPlusAndMinus(Plus | Minus $binaryOp): ?Expr
 
     private function processBinaryMulAndDiv(Mul | Div $binaryOp): ?Expr
     {
+        if ($binaryOp->left instanceof ClassConstFetch || $binaryOp->right instanceof ClassConstFetch) {
+            return null;
+        }
+
         if (! $this->areNumberType($binaryOp)) {
             return null;
         }