[DeadCode] RemoveDeadZeroAndOneOperationRector should not remove Constants

[TwanVermeulen]

I'm curious about your thoughts!
Sometimes we use constants that explain a certain number by words.

If the constant number does not change the outcome of a mathematical expression, it's currently removed by RemoveDeadZeroAndOneOperationRector. So for constants that have a value of 1 this would be the case.
I would prefer to keep the constant, since it's added to increase readability.

What do you think? I added a test case that currently fails, but should pass imho.

Thanks for your input

[TomasVotruba]

Hi, the constants should not be removed indeed 👍

Could you send fix as well? Thanks

[TwanVermeulen]

@TomasVotruba I added a fix. I do see some failed checks, but I'm not sure if they are related to my changes. Please let me know if there's any action required from my side.

[TwanVermeulen]

@TomasVotruba all checks are green after merging latest main

[samsonasik]

second part is unneeded for equal content

Suggested change

	?>
	-----
	<?php
	namespace Rector\Tests\DeadCode\Rector\Plus\RemoveDeadZeroAndOneOperationRector\Fixture;
	class SkipConstants
	{
	public const ONE = 1;
	public function run()
	{
	$value = 5 * self::ONE;
	$value = 5 / self::ONE;
	$value = self::ONE * 5;
	$value = self::ONE / 5;
	}
	}
	?>

[TomasVotruba]

Indeed, I'll get this merged and fixup as the main work is done 👍

[TomasVotruba]

@TwanVermeulen Thank you, this is good to go 👍 🙂