Skip divide in NumericReturnTypeFromStrictScalarReturnsRector (#4298)

rectorphp · Jun 19, 2023 · 41184e1 · 41184e1
1 parent cc70ba9
commit 41184e1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 29 deletions.
diff --git a/...lassMethod/NumericReturnTypeFromStrictScalarReturnsRector/Fixture/divide_integers.php.inc b/...lassMethod/NumericReturnTypeFromStrictScalarReturnsRector/Fixture/divide_integers.php.inc
diff --git a/...ethod/NumericReturnTypeFromStrictScalarReturnsRector/Fixture/skip_divide_integers.php.inc b/...ethod/NumericReturnTypeFromStrictScalarReturnsRector/Fixture/skip_divide_integers.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\NumericReturnTypeFromStrictScalarReturnsRector\Fixture;
+
+final class SkipDivideIntegers
+{
+    public function resolve(int $first, int $second)
+    {
+        return $first / $second;
+    }
+}
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/NumericReturnTypeFromStrictScalarReturnsRector.php b/rules/TypeDeclaration/Rector/ClassMethod/NumericReturnTypeFromStrictScalarReturnsRector.php
@@ -8,7 +8,6 @@
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\BinaryOp;
 use PhpParser\Node\Expr\BinaryOp\BitwiseAnd;
-use PhpParser\Node\Expr\BinaryOp\Div;
 use PhpParser\Node\Expr\BinaryOp\Minus;
 use PhpParser\Node\Expr\BinaryOp\Mod;
 use PhpParser\Node\Expr\BinaryOp\Mul;
@@ -101,7 +100,7 @@ public function refactor(Node $node): ?Node
         }
 
         // @see https://chat.openai.com/share/a9e4fb74-5366-4c4c-9998-d6caeb8b5acc
-        if ($return->expr instanceof Minus || $return->expr instanceof Plus || $return->expr instanceof Mul || $return->expr instanceof Div || $return->expr instanceof Mod || $return->expr instanceof BitwiseAnd || $return->expr instanceof ShiftRight || $return->expr instanceof ShiftLeft) {
+        if ($return->expr instanceof Minus || $return->expr instanceof Plus || $return->expr instanceof Mul || $return->expr instanceof Mod || $return->expr instanceof BitwiseAnd || $return->expr instanceof ShiftRight || $return->expr instanceof ShiftLeft) {
             return $this->refactorBinaryOp($return->expr, $node);
         }